Moar options #278
Merged
Moar options #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 165 165
Lines 47672 47672
=======================================
Hits 44389 44389
Misses 3283 3283
Continue to review full report at Codecov.
|
|
@vtnate I'd recommend using the EER for the SEER 14 AC from BEopt, as that's probably what the person who created the upgrade used. Hopefully it's reasonably consistent with what you found. (Note that BEopt directly gets its data from the REMDB, so fridge/freezer should already be consistent.) |
|
@shorowit Got it, thanks for the explaining that connection. Yes, fridge/freezer are already consistent. Looks like BEOpt used a rounded version of what I had for EER. I updated options_lookup to match BEOpt. |
ejhw
reviewed
Jun 24, 2019
resources/options_lookup.tsv
Outdated
| Misc Freezer None ResidentialMiscLargeUncommonLoads has_freezer=false freezer_rated_annual_energy=935 freezer_mult=0.342 "freezer_weekday_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_weekend_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_monthly_sch=0.837, 0.835, 1.084, 1.084, 1.084, 1.096, 1.096, 1.096, 1.096, 0.931, 0.925, 0.837" freezer_location=auto | ||
| Misc Freezer "EF 12, National Average" ResidentialMiscLargeUncommonLoads has_freezer=true freezer_rated_annual_energy=935 freezer_mult=0.342 "freezer_weekday_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_weekend_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_monthly_sch=0.837, 0.835, 1.084, 1.084, 1.084, 1.096, 1.096, 1.096, 1.096, 0.931, 0.925, 0.837" freezer_location=auto | ||
| Misc Freezer "EF 16, 2001 Fed Standard (reference freezer)" ResidentialMiscLargeUncommonLoads has_freezer=true freezer_rated_annual_energy=712 freezer_mult=0.342 "freezer_weekday_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_weekend_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_monthly_sch=0.837, 0.835, 1.084, 1.084, 1.084, 1.096, 1.096, 1.096, 1.096, 0.931, 0.925, 0.837" freezer_location=auto | ||
| Misc Freezer "EF 18, 2008 Energy Star" ResidentialMiscLargeUncommonLoads has_freezer=true freezer_rated_annual_energy=641 freezer_mult=0.342 "freezer_weekday_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_weekend_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_monthly_sch=0.837, 0.835, 1.084, 1.084, 1.084, 1.096, 1.096, 1.096, 1.096, 0.931, 0.925, 0.837" freezer_location=auto | ||
| Misc Freezer "EF 20, 2008 Energy Star Most Efficient" ResidentialMiscLargeUncommonLoads has_freezer=true freezer_rated_annual_energy=568 freezer_mult=0.342 "freezer_weekday_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_weekend_sch=0.040, 0.039, 0.038, 0.037, 0.036, 0.036, 0.038, 0.040, 0.041, 0.041, 0.040, 0.040, 0.042, 0.042, 0.042, 0.041, 0.044, 0.048, 0.050, 0.048, 0.047, 0.046, 0.044, 0.041" "freezer_monthly_sch=0.837, 0.835, 1.084, 1.084, 1.084, 1.096, 1.096, 1.096, 1.096, 0.931, 0.925, 0.837" freezer_location=auto |
There was a problem hiding this comment.
freezer_mult=0.342 should be freezer_mult=1.0` for these three, assuming you want them to have a "whole freezer" as opposed to a "national average fraction of a freezer".
ejhw
reviewed
Jun 24, 2019
ejhw
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add items to options_lookup available in master branch
Energy usage for fridge/freezers came from https://remdb.nrel.gov/
EER was calculated from SEER (for SEER 14 AC) using this calculator: https://power-calculation.com/EER_SEER_COP_conversion_air_conditioning.phpEER was copied from BEOpt, which gets its data from https://remdb.nrel.gov/