Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow infiltration % reduction upgrades #840

Closed
wants to merge 23 commits into from

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Feb 23, 2022

Pull Request Description

Closes #629. Closes #736.

Also, adds incremental costs testing to UpgradeCosts.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected integration/regression test changes

@joseph-robertson joseph-robertson added this to the ResStock v2.6.0 Beta milestone Feb 23, 2022
@joseph-robertson joseph-robertson self-assigned this Feb 23, 2022
@shorowit
Copy link
Contributor

@joseph-robertson I assume you have a plan for the upgrade costing (i.e., cost multiplier) side of things? I would think that whatever you implement for infiltration reduction upgrades would also work for attic insulation upgrades.

@joseph-robertson
Copy link
Contributor Author

@shorowit Yes I was going to do something close to what you proposed in #629 (comment).

I can address the item in #42 in a separate PR.

@@ -30,7 +30,8 @@ def self.CostMultiplierChoices
'Size, Cooling System Primary (kBtu/h)',
'Size, Heat Pump Backup Primary (kBtu/h)',
'Size, Water Heater (gal)',
'Flow Rate, Mechanical Ventilation (cfm)'
'Flow Rate, Mechanical Ventilation (cfm)',
'Infiltration Reduction * Floor Area, Conditioned (ACH50 * ft^2)'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Delta ACH50"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants