Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle incremental costs of (1) adding attic insulation and (2) reducing (%) infiltration #848

Merged
merged 89 commits into from
Apr 6, 2022
Merged

Handle incremental costs of (1) adding attic insulation and (2) reducing (%) infiltration #848

merged 89 commits into from
Apr 6, 2022

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Mar 4, 2022 •
edited
Loading

Pull Request Description

Closes #42. Closes #629. Closes #736.

Also, adds incremental costs testing to UpgradeCosts.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected integration/regression test changes

joseph-robertson and others added 30 commits February 23, 2022 15:53
@joseph-robertson
Add optional air leakage value reduction argument.
aa3a35e
@joseph-robertson
Add upgrade option for 25% infiltration reduction.
3c2ecf0
@joseph-robertson
Add new upgrade option to project yml files.
8c72d8b
Latest results.
2c96bfb
@joseph-robertson
Attempt at cost multiplier for incremental change.
aa7eec7
@joseph-robertson
Merge branch 'infil-percent-reduction' of github.com:NREL/resstock in…
7ae7369 
…to infil-percent-reduction
@joseph-robertson
Update upgrade cost test file.
9592819
Latest results.
388df0d
@joseph-robertson
Change the cost multiplier.
0204727
@joseph-robertson
Add new rval increase cost multiplier.
41019e7
@joseph-robertson
Add new rval increase argument.
51c975a
@joseph-robertson
Update upgrade costs for new multiplier.
e0fcc98
@joseph-robertson
Add new rval increase upgrade option to lookup.
8198c43
@joseph-robertson
Test new rval increase upgrade option.
d1592c6
Latest results.
f51bffb
Latest results.
67331ba
@joseph-robertson
Update.
dfefe20
@joseph-robertson
Merge branch 'develop' into rval-percent-increase
81baf8c
@joseph-robertson
Merge branch 'develop' into infil-percent-reduction
eae0bbc
Latest results.
b6d6cbb
Latest results.
2371e66
@joseph-robertson
Merge branch 'develop' into infil-percent-reduction
aaa6f2c
@joseph-robertson
Merge branch 'develop' into rval-percent-increase
5171748
Latest results.
f8d6af3
Latest results.
e6a46bb
@joseph-robertson
Merge branch 'develop' into infil-percent-reduction
c3d114b
@joseph-robertson
Merge branch 'develop' into rval-percent-increase
1ea6a64
@joseph-robertson
Update changelog and docs.
cc028a7
@joseph-robertson
Update changelog and docs.
fc461cd
@joseph-robertson
Back upgrade datapoints back down to 1.
86dce80
joseph-robertson and others added 15 commits March 23, 2022 16:35
@joseph-robertson
Try apply_logic in testing upgrades yml.
249919b
@joseph-robertson
Run temporary upgrades2 on buildstock_docker and upload results.
c1b14df
@joseph-robertson
Move cost multiplier registration back up.
fb5d1f8
@joseph-robertson
Merge branch 'develop' into incremental-costs
1cd71e0
@joseph-robertson
Merge branch 'develop' into incremental-costs
0e35e97
Latest results.
b1bfe82
@ekpresent
making the project file fail again intentionally
3d3740c
@ekpresent
merge in main branch
ccec711 
Merge branch 'incremental-costs' of https://github.com/NREL/resstock into incremental-costs
@joseph-robertson
Merge branch 'develop' into incremental-costs
4276cdf
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from b3afe1c1fe08..5c0bd…
f898889 
…9b56438

5c0bd9b56438 Merge pull request #1012 from NREL/additional-properties-updates
8fa43c9bb448 Update Changelog.md
2569aeb17804 Minor cleanup. Reverts EPvalidator.xml and docs changes.
39032492560d Latest results.
5717b02e84a1 Merge branch 'master' into additional-properties-updates
eab2693294df Update description and docs.
a0176f01e5cb Merge pull request #1010 from NREL/fix_timeseries_emissions
15dc8bc1f0b0 Latest results.
3961f4dfd771 Update Changelog.md [ci skip]
6e981e11bc0a Latest results.
c8ea2273a98e Test more characters.
dea7fa60c414 Latest results.
ddc83ef99c93 Merge branch 'master' into additional-properties-updates
b5d2f37c644f Fixes and updates to tear down method.
63df131dbb14 Add convenience method for retrieving additional properties.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 5c0bd9b5643882c90654364a6fa3528b36cf6afd
@joseph-robertson
Merge commit 'f8988894a0be2f4254ca3585b6bafa7b71f03d30' into incremen…
e626bfd 
…tal-costs
@joseph-robertson
Updates for new additional properties capability.
0ab0e32
@joseph-robertson
Some cleanup.
15e9f2a
@joseph-robertson
Clean up temporary code.
e1e90e4
@joseph-robertson
Merge branch 'develop' into incremental-costs
b83e76f
@shorowit shorowit mentioned this pull request Mar 30, 2022
Closed
5 tasks
ekpresent
ekpresent approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@ekpresent ekpresent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at this point

@joseph-robertson joseph-robertson merged commit a8c776a into develop Apr 6, 2022
@joseph-robertson joseph-robertson deleted the incremental-costs branch April 6, 2022 19:07
@shorowit shorowit mentioned this pull request Apr 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit left review comments

@ekpresent ekpresent ekpresent approved these changes

Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
None yet
Milestone
ResStock v3.0.0
3 participants
@joseph-robertson @ekpresent @shorowit