Handle incremental costs of adding attic insulation #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
changed the title
shorowit
reviewed
Mar 2, 2022
| @@ -15,6 +15,7 @@ def test_SFD_1story_FB_UA_GRG_MSHP_FuelTanklessWH | |||
| 'Wall Area, Below-Grade (ft^2)' => 292.0 + 525.0 + 196.0 + 429.0 + 96.0 * 2, | |||
| 'Floor Area, Conditioned (ft^2)' => 2250.0 * 2, | |||
| 'Floor Area, Attic (ft^2)' => 2250.0, | |||
| 'Insulation Increase * Floor Area, Attic (Delta R-value * ft^2)' => (61.6 - 39.3) * 2250.0, | |||
There was a problem hiding this comment.
Shoot. This is a problem. We really want to use the cavity R-value, not assembly R-value, for the calculation. E.g., this should presumably be 60.0 - 40.0. Not sure if we're okay with the fact that it's close but not exact, or we need to figure out how to address this...
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #42.
Also, adds incremental costs testing to
UpgradeCosts.Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run