-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to discuss: Change "Module" in functions dataset to "Model"? #88
Labels
Comments
rjhanes
added
enhancement
New feature or request
question
Further information is requested
labels
Jun 17, 2022
I agree |
Works for me.
…On Fri, Jun 17, 2022 at 5:53 PM Rebecca Hanes ***@***.***> wrote:
@TJTapajyoti <https://github.com/TJTapajyoti> , @SamBaldwinDOE
<https://github.com/SamBaldwinDOE> , and @clhughes
<https://github.com/clhughes> :
This is what the functions dataset currently looks like:
Technology Style Module Capital Fixed Production Metrics Notes
Biorefinery v1 numpy tutorial_biorefinery capital_cost fixed_cost
production metrics
I suggest we rename the "Module" column to "Model". It's technically
correct that every technology is its own module within Tyche, but I think
the nomenclature is confusing.
This is a super-minor, non-functional change, so if there are no
objections I'll implement this in time for our Q3 deliverable release.
—
Reply to this email directly, view it on GitHub
<#88>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK2OV5ZBB2WXZO5LQBA4FOLVPTXW5ANCNFSM5ZDQXZCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
rjhanes
added a commit
that referenced
this issue
Oct 4, 2022
rjhanes
added a commit
that referenced
this issue
Oct 4, 2022
rjhanes
added a commit
that referenced
this issue
Oct 4, 2022
21 tasks
Closed in PR #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@TJTapajyoti , @SamBaldwinDOE , and @clhughes :
This is what the functions dataset currently looks like:
I suggest we rename the "Module" column to "Model". It's technically correct that every technology is its own module within Tyche, but I think the nomenclature is confusing.
This is a super-minor, non-functional change, so if there are no objections I'll implement this in time for our Q3 deliverable release.
The text was updated successfully, but these errors were encountered: