Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to discuss: Change "Module" in functions dataset to "Model"? #88

Closed
rjhanes opened this issue Jun 17, 2022 · 3 comments
Closed

to discuss: Change "Module" in functions dataset to "Model"? #88

rjhanes opened this issue Jun 17, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@rjhanes
Copy link
Collaborator

rjhanes commented Jun 17, 2022

@TJTapajyoti , @SamBaldwinDOE , and @clhughes :

This is what the functions dataset currently looks like:

Technology Style Module Capital Fixed Production Metrics Notes
Biorefinery v1 numpy tutorial_biorefinery capital_cost fixed_cost production metrics  

I suggest we rename the "Module" column to "Model". It's technically correct that every technology is its own module within Tyche, but I think the nomenclature is confusing.

This is a super-minor, non-functional change, so if there are no objections I'll implement this in time for our Q3 deliverable release.

@rjhanes rjhanes added enhancement New feature or request question Further information is requested labels Jun 17, 2022
@rjhanes rjhanes added this to the Tyche Release 1.0 milestone Jun 17, 2022
@rjhanes rjhanes self-assigned this Jun 17, 2022
@tjlca
Copy link
Collaborator

tjlca commented Jun 22, 2022

I agree

@SamBaldwinDOE
Copy link
Collaborator

SamBaldwinDOE commented Jun 23, 2022 via email

@rjhanes
Copy link
Collaborator Author

rjhanes commented Oct 4, 2022

Closed in PR #108

@rjhanes rjhanes closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants