Fix max recursion #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 29, 2020 19:19
|
Why a new PR instead of adding commits to #44? It would be nice to keep the discussion in one place if possible. |
Actually, what I want to do is remove test part of this PR and merge this first. Then proceed the other one, what do you think? |
|
Do you mean first fix the recursion issue in this PR and then add the hypothesis-related code in #44? |
|
This is duplicated work which has been included in #44 . So, close it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to solve #51 and #44 (comment).
Main difference comparing to #44 is addressing fix recursion.