-
Notifications
You must be signed in to change notification settings - Fork 9
ENH/API: Update database for moved files #58
Conversation
.. _MEP-index: | ||
|
||
################################ | ||
Matplotlib Enhancement Proposals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filestore, not matplotlib
The idea is that |
Have you thought about how to implement the
|
5e3c88c
to
92ebe91
Compare
And with that I declare preliminary victory. Still to do:
@heroux proof of concept of moving files + updating the db to be aware of it. |
my first @ mentioned ! Great! |
- delete resources | ||
- verify data at both file system and Datum level | ||
|
||
Implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider updating this or moving it to a separate branch. Misinformation is worse than no information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh, it is pretty clearly labeled as a proposal and I think the outline of this is still correct long term, what is implemented is a fraction of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough
@tacaswell Done with first round of review. Ping me when there are docstrings and I'll check those as well. |
pytest is magic
Shifts folders from the chroot to resource_path and back.
Most of these missing lines (excluding spe) are raised exceptions which are not exercised, or LPy work arounds |
|
||
''' | ||
|
||
def insert_resource(self, spec, resource_path, resource_kwargs, root=''): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
- fixed typo in exception strings - added time index to resource_update collection to improve sort performance
Obviously a major work in progress