This repository has been archived by the owner on Aug 30, 2017. It is now read-only.
WIP: Listify numpy arrays #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 90.35% 90.18% -0.18%
==========================================
Files 4 4
Lines 477 489 +12
Branches 75 80 +5
==========================================
+ Hits 431 441 +10
- Misses 31 33 +2
Partials 15 15
Continue to review full report at Codecov.
|
|
https://github.com/NSLS-II/bluesky/blob/b92e1a42f188fd7efa982c3ac1c8a064c1879a50/bluesky/utils.py#L837 is how we are currently doing this. This has the advantage of not copying lists. |
danielballan
reviewed
May 2, 2017
metadatastore/mds.py
Outdated
| @@ -656,6 +657,13 @@ def insert_descriptor(self, run_start, data_keys, time, uid, **kwargs): | |||
| data_keys=data_keys, | |||
| time=time, uid=uid, | |||
| **kwargs) | |||
| def _sanitize_np(self, val): | |||
There was a problem hiding this comment.
Since this does not need access to self I'd suggest making it top-level function rather than a method. It's easier to test that way.
ghost
mentioned this pull request
tacaswell
approved these changes
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge.
In accordance with bluesky/bluesky#674
TODO: