feat: add embedding_params to BasicEmbeddingsIndex #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pouyanpi
added
enhancement
- Added `embedding_params` attribute to `BasicEmbeddingsIndex` class. - Updated the constructor to accept `embedding_params`. - Modified `_init_model` method to pass `embedding_params` to `init_embedding_model`. - Updated `init_embedding_model` function to handle `embedding_params`. - Adjusted `NIMEmbeddingModel` and `OpenAIEmbeddingModel` to accept additional parameters. - Updated `LLMRails` to handle default embedding parameters. improve style
Pouyanpi
force-pushed
the
feat/embedding-provider-params
branch
from
ee2dc88 to
0182667
Compare
Pouyanpi
added
status: in review
and removed
status: in progress
cparisien
approved these changes
Jan 31, 2025
|
@cparisien typos fixed 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embedding_paramsattribute toBasicEmbeddingsIndexclass.embedding_params._init_modelmethod to passembedding_paramstoinit_embedding_model.init_embedding_modelfunction to handleembedding_params.NIMEmbeddingModelandOpenAIEmbeddingModelto accept additional parameters.LLMRailsto handle default embedding parameters.TODO
Description
The user is able to pass params to an embedding provider, like base_url of a local NIM embedding model.