Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resize jupyter notebook. #2189

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Add Resize jupyter notebook. #2189

merged 2 commits into from
Aug 7, 2020

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Aug 7, 2020

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Why we need this PR?

Pick one, remove the rest

  • It adds documentation to Resize, because it has too many options to be self-explanatory.

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    • Written?
    • Added to index.rst
  • Affected modules and functionalities:
    • Documentation
  • Key points relevant for the review:
    • N/A
  • Validation and testing:
    • N/A
  • Documentation (including examples):
    • This is docs

JIRA TASK: DALI-1555

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient mzient requested a review from a team August 7, 2020 10:52
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@mzient mzient changed the title Add resize jupyter notebook. Add Resize jupyter notebook. Aug 7, 2020
@review-notebook-app
Copy link

review-notebook-app bot commented Aug 7, 2020

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2020-08-07T11:36:15Z
----------------------------------------------------------------

I would explain what the DataNode is.

I would briefly tell what "stretch". does.


mzient commented on 2020-08-07T12:07:29Z
----------------------------------------------------------------

Good point about "stretch", because it's not actually default.

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2020-08-07T11:36:16Z
----------------------------------------------------------------

resize_x / resize_y -> resize_x, resize_y


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2020-08-07T11:36:16Z
----------------------------------------------------------------

I would give an example for he image is scaled so that no dimension is smaler than specified (additionally, max_size argument may be used to limit upscaling of inputs with very high aspect ratios) to show what takes the precedence. I think I was a bit surprised in one of the Resize test cases.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2020-08-07T11:36:17Z
----------------------------------------------------------------

width+height -> width, height


Copy link
Contributor Author

mzient commented Aug 7, 2020

Good point about "stretch", because it's not actually default.


View entire conversation on ReviewNB

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Copy link
Contributor Author

mzient commented Aug 7, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1528561]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1528561]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1528561]: BUILD PASSED

@mzient mzient merged commit 6ef3ac4 into NVIDIA:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants