Rework getting started #2729
Rework getting started #2729
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
!build |
|
CI MESSAGE: [2112355]: BUILD STARTED |
|
CI MESSAGE: [2112355]: BUILD PASSED |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:33Z
^^ This paragraph is a little bit convoluted. It could use some simplification. Perhaps out of the scope of this PR but wanted to mention it.
I'd add a link to the documentation on the "Pipeline" word. awolant commented on 2021-02-26T15:23:01Z
|
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:34Z "very simple pipeline for classifier" - > "very simple pipeline for a classification task " awolant commented on 2021-02-26T15:23:09Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:34Z Consider making pipeline_def is a link to the documentation. awolant commented on 2021-02-26T15:25:14Z Done, by adding new sentence with the link at the end of the paragraph. |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:35Z Maybe "by calling simple_pipeline, which creates a pipeline instance, and calling build on it." Your call. If you decide to keep the current wording, please add "on the newly created pipeline"
awolant commented on 2021-02-26T15:26:51Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:35Z is a list of ... -> Isn't it a tuple? each contains a list of tensors on the CPU -> each containing a list of CPU tensors awolant commented on 2021-02-26T15:28:13Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:36Z Please remove this help from here, and simply add that for more info go to the Rotate documentation (with a link)
awolant commented on 2021-02-26T15:33:27Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:36Z How is specifying fill_value=0 is better to visualize the results? Isn't it the default? awolant commented on 2021-02-26T14:56:31Z No, if you don't do it the default is to copy the border pixel color. awolant commented on 2021-02-26T15:39:16Z To be more specific, this is the quote from the doc:
So technically, the default values is 0.0, but unless you put it literally it is not used.
jantonguirao commented on 2021-02-26T16:08:36Z I understand |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:37Z The help output for rotate operation tell us that angle parameter can accept - > rotate's angle parameter can accept
examples of support operations -> examples of operations
a pipeline with random rotation -> a pipeline that rotates images by a random angle awolant commented on 2021-02-26T15:44:43Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:37Z This sentence doesn't make sense anymore. There's no constructor in fn API. awolant commented on 2021-02-26T15:53:02Z Fixed |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:38Z Let us modify the previous random_rotated_pipeline example to use the GPU for the rotation. awolant commented on 2021-02-26T15:53:27Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:39Z to use GPU -> to use the GPU input to the rotate -> "input to rotate" or "input to the rotate operation" awolant commented on 2021-02-26T15:46:24Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:39Z I'd remove "In all execution paths" awolant commented on 2021-02-26T15:48:19Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:40Z I am missing a sentence about what "mixed" means. awolant commented on 2021-02-26T15:50:10Z There is a sentence after the code sample that tells what does it mean for the operation to be |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:40Z Wondering, why did it go down? awolant commented on 2021-02-26T15:51:08Z Different PC, maybe different version of libraries etc. |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:41Z moving the decoding partially to the GPU -> using GPU accelerated decoding
awolant commented on 2021-02-26T15:51:32Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:42Z example below is a quick reference - > this examples can be used as a quick reference. but with -> but with the legacy awolant commented on 2021-03-01T14:59:58Z
|
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:42Z Same wording points as in the other example. I won't be repeating other points listed in the other notebook, please consider those suggestions for both notebooks when applicable. awolant commented on 2021-03-01T15:47:58Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:43Z by calling the build function awolant commented on 2021-03-01T15:03:55Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:43Z get a batch awolant commented on 2021-03-01T15:04:40Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:44Z 2 changes to the -> 2 changes to Shuffling is performed using -> Shuffling is performed by using When reader - > When the reader a next image - > the next image spot in a buffer - > spot in the buffer
awolant commented on 2021-03-01T15:05:49Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:44Z the previous example of the ... -> our previous ... to use GPU for rotation operator -> to use the GPU implementation of the Rotate operator awolant commented on 2021-03-01T15:06:52Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:45Z to use GPU - > to use the GPU awolant commented on 2021-03-01T15:07:21Z Done |
|
View / edit / reply to this conversation on ReviewNB jantonguirao commented on 2021-02-26T14:38:46Z This sentence was lacking in the other notebook. jantonguirao commented on 2021-02-26T16:11:32Z Ignore this, I see that the sentence is there |
|
View / edit / reply to this conversation on ReviewNB mzient commented on 2021-03-01T16:44:29Z Nitpick: try other seeds, here the difference between the 1st row and fixed 10 degrees is not as obvious as we could wish for. awolant commented on 2021-03-01T17:23:45Z Done |
|
Done View entire conversation on ReviewNB |
4 similar comments
|
Done View entire conversation on ReviewNB |
|
Done View entire conversation on ReviewNB |
|
Done View entire conversation on ReviewNB |
|
Done View entire conversation on ReviewNB |
|
Done, also updated View entire conversation on ReviewNB |
|
Done View entire conversation on ReviewNB |
View entire conversation on ReviewNB |
|
Done View entire conversation on ReviewNB |
|
!build |
|
CI MESSAGE: [2119823]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [2120824]: BUILD FAILED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
awolant
force-pushed
the
fn_getting_started
branch
from
07dd761
to
f19b2e4
Compare
|
!build |
|
CI MESSAGE: [2120926]: BUILD STARTED |
|
CI MESSAGE: [2120926]: BUILD PASSED |
|
!build |
|
CI MESSAGE: [2122861]: BUILD STARTED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
CI MESSAGE: [2122861]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [2123102]: BUILD STARTED |
|
CI MESSAGE: [2123102]: BUILD PASSED |
Why we need this PR?
What happened in this PR?
Docs
JIRA TASK: [Use DALI-1822,1871]