-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image processing workflow #806
Conversation
👍 for image labels in torch. E.G. providing a normal map and a diffuse map and produce a shaded image (multiple input), or provide a single image and produce a super-resolution and a segmentation map (multiple output) As far as you know, can this be done by creating the DB manually, and adding multi-channel images (for labels, sources, or both)? |
Hi @pansk we are using Caffe You can store multiple images in your unencoded Given this Would that work for you? |
fb6277d
to
e51aba6
Compare
from bs4 import BeautifulSoup | ||
import json | ||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major nitpick here, but PEP8 likes to separate standard library imports and 3rd party imports:
Imports should be grouped in the following order:
- standard library imports
- related third party imports
- local application/library specific imports
You should put a blank line between each group of imports.
https://www.python.org/dev/peps/pep-0008/#imports
I've been trying to follow that format in our code since #501.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I am not sure I get the difference between a standard library import and a 3rd party import. Is it correct to say that numpy
and PIL.Image
are 3rd party imports and json
, os
, tempfile
are standard library imports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what they're distinguishing between are packages that come with a standard Python install (i.e. apt-get install python
) vs. add-on packages (i.e. pip install Flask
). At least, that's been my interpretation. I'm open to push-back if you think it's dumb.
import json
import os
import tempfile
from bs4 import BeautifulSoup
import numpy as np
import PIL.Image
from digits import extensions
import digits.test_views
from digits.utils import constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it, thanks!
e51aba6
to
7a51e51
Compare
427dea0
to
2deb27c
Compare
f50bc5c
to
6f14123
Compare
To be used with networks where the input and the output are images
6f14123
to
09b1854
Compare
09b1854
to
cd5a050
Compare
Rebased and updated according to comments: |
hi, gheinrich. |
This adds data and view extensions to train image processing networks in DIGITS. This may be used for de-noising, super-resolution, segmentation, etc.
The image processing data extension creates datasets for which both the input and the label are images.
The image view extension displays the network output as an image.
Only works with Caffe for now. Torch wrappers need to be updated to deal with image labels (currently only scalar or vector labels are supported).