Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image segmentation workflow #830

Merged
merged 8 commits into from
Aug 2, 2016

Conversation

gheinrich
Copy link
Contributor

I am planning to break this down into smaller PRs but I am interested in getting early feedback.
This PR builds upon #806 and adds:

  • more flexibility in the choice of Torch labels (now we can use anything that fits in a Datum object)
  • the ability to use a variable image size during inference (we need this to exploit the potential of FCNs)
  • a walk-through and a simple example

@pansk @TimZaman : would you like to have a look?

I understand some of these changes might conflict with #777. I am willing to wait for #777 to be merged first then I will rebase.

@TimZaman
Copy link
Contributor

TimZaman commented Jun 10, 2016

Haha, Greg, this is so cool, seems you've been busy. I don't see any significant conflicts with #777 if I skim through the Files Changed. I will test this weekend. I'm unsure if your 3 bulletpoints cover the +1600 locs though, anything else to keep an eye out for?

@gheinrich
Copy link
Contributor Author

Thanks Tim, I'm particularly interested in your feedback on 2645de3 and 902ff94, if you have the leisure to take a glance :-)

@gheinrich gheinrich changed the title [DONT MERGE] Image segmentation workflow Image segmentation workflow Jul 11, 2016
@gheinrich
Copy link
Contributor Author

Depends on PRs #806, #880, #881

@hariprasadravi
Copy link

Hello, I'm getting an error "Check failed: registry.count(type) == 1 (0 vs. 1) Unknown layer type: L1Loss" when I attempt to create a model using the tutorial. Is there an alternative?

@gheinrich
Copy link
Contributor Author

Hello, to use the Caffe model you need nv-caffe 0.15. Or you can use EuclideanLoss however you'll need to set the learning rate to a very small value.

@hariprasadravi
Copy link

EuclideanLoss with learning rate 1e-7 worked. Thanks!

@hariprasadravi
Copy link

Hi @gheinrich I would like to know if you might have worked on more complex models for image segmentation to test this branch. I would be interested to test on some of my own dataset.

@gheinrich
Copy link
Contributor Author

Hello @hariprasadravi I haven't yet found the time to try more complex problems. I highly recommend this paper though: Fully Convolutional Networks for Semantic Segmentation

tooltip="Indicate a folder full of images. There must be one "
"image per image in the source image folder. Image "
"names do not matter but the images should match "
"those of the source folder, when sorted alphanumerically."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit loose to me. Why not match the KITTI format and require matching filenames (without extensions)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree... I made it like this initially because in the first dataset I used all images were one off e.g. img1.jpg in target folder corresponded to img0.jpg in source folder. I can change this.

@lukeyeager
Copy link
Member

Made it through the tutorial - this is super cool!

To be used with networks where the input and the output are images
Labels were restricted to scalars (classification) or vectors (regression).
This change extends supported label types to anything that fits in an LMDB.
Small refactoring of datum decoding.
Caffe and Torch pre-processors are updated to handle the case where the input image dimensions do not match those of the training set.
@gheinrich gheinrich merged commit 5618be4 into NVIDIA:master Aug 2, 2016
@gheinrich gheinrich deleted the dev/image-segmentation branch November 30, 2016 16:49
SlipknotTN pushed a commit to cynnyx/DIGITS that referenced this pull request Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants