Adding UNet3+ support for Tensorflow 2.0 #1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi |
nv-kkudrynski
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Hi @hamidriasat
- are you OK to change license from MIT to Apache2 which is our default? See here.
- are you OK to move the project under subfolder 'contrib' i.e: TensorFlow2/Segmentation/Contrib/UNet3P?
- other minor comments within a review, please have a look.
|
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
|
I have read the DCO Document and I hereby sign the DCO |
|
Yes, I have no issue updating license and directory according to your requirements. I have completed all three changes
Only the requested changes have been made, rest of the code is similar. |
nv-kkudrynski
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNet3+ in Tensorflow 2.0. For more details about the code and functionality please check
README.mdfile.Things to update while accepting pull request
in the
Installationsection from my forked repo pathI can provide trained model weights in case you want them for testing.
I have tested everything thoroughly but if anything is missing please let me know.
Hope you will like my work.