Save Virtual Prompt Weights Only #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
titu1994
requested changes
May 24, 2022
|
And any modification of core needs two core devs to approve it. FYI @ericharper |
Signed-off-by: Virginia Adams <vadams@nvidia.com>
titu1994
requested changes
May 24, 2022
There was a problem hiding this comment.
@ericharper can you work with Virginia to properly use the base class methods. This currently basically just replaces save to with custom impl which will just drift apart more and more from the base implementation
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
|
This pull request introduces 3 alerts when merging 89e374d into ff9bc79 - view on LGTM.com new alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
vadam5
changed the title
|
This pull request introduces 3 alerts when merging 9b3401d into ff9bc79 - view on LGTM.com new alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
titu1994
previously approved these changes
May 26, 2022
Signed-off-by: Virginia Adams <vadams@nvidia.com>
…ub.com/NVIDIA/NeMo into prompt_learning_preserve_gpt_artifacts
titu1994
approved these changes
May 26, 2022
yaoyu-33
pushed a commit
that referenced
this pull request
May 31, 2022
* Added gpt artifact preservation method Signed-off-by: Virginia Adams <vadams@nvidia.com> * Removed redundent line of code Signed-off-by: Virginia Adams <vadams@nvidia.com> * Moved preserve artifact method to NLPSaveStoreConnector Signed-off-by: Virginia Adams <vadams@nvidia.com> * Saving only prompt table weights in final nemo file Signed-off-by: Virginia Adams <vadams@nvidia.com> * Put NLP overrides back the way it was Signed-off-by: Virginia Adams <vadams@nvidia.com> * Put NLP overrides back the way it was Signed-off-by: Virginia Adams <vadams@nvidia.com> * Added doc strings for new methods Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python style fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * Added loading state dict backward compatibility Signed-off-by: Virginia Adams <vadams@nvidia.com> * Upddated prompt learning inference to reset frozen model path Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python formatting fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * Update prompt_learning.rst * Update prompt_learning.rst * Update prompt_learning.rst * changed model_file to gpt_model_file, updated CI tests Signed-off-by: Virginia Adams <vadams@nvidia.com> Signed-off-by: Yu Yao <yuya@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all GPT/Frozen model configs and weights from Prompt Learning Model's .nemo file. After training has ended, the prompt learning model now only saves prompt table parameters. During training, intermediate checkpoint files may also have prompt encoder parameters.
Collection: BigNLP
Usage
The final .nemo checkpoint file contains
where model_weights.ckpt only has prompt table params
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information