Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megatron norm #5411

Merged
merged 84 commits into from
Nov 15, 2022
Merged

Megatron norm #5411

merged 84 commits into from
Nov 15, 2022

Conversation

borisfom
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

okuchaiev and others added 30 commits October 25, 2022 10:45
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Vahid <vnoroozi@nvidia.com>

Signed-off-by: Vahid <vnoroozi@nvidia.com>
[Tools][ASR] Tool for generating data using simulated RIRs

Signed-off-by: Ante Jukić <ajukic@nvidia.com>
* Add files for commit

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Added parallelism on p-value search

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Changed speaker clustering to accept torch.tensor

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Cleaned up the code and tested to have identical output

Signed-off-by: Taejin Park <tango4j@gmail.com>

* update on Notebook demo

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Added eigvalsh for faster eig val calculation:

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Remove NMESC_JitScriptedModule.ipynb

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Cleaned code and style fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Modified MSDD framework to fit torch-scripted clustering

Signed-off-by: Taejin Park <tango4j@gmail.com>

* LGTM fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* removed all string based timestamps

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Removed unnecessary lines

Signed-off-by: Taejin Park <tango4j@gmail.com>

* removed redundant lines

Signed-off-by: Taejin Park <tango4j@gmail.com>

Signed-off-by: Taejin Park <tango4j@gmail.com>
* Update perturb.py

Add checking for channels mismatch for audio and noise data, throw an exception if they have different number of channels. Also fixed `perturb_with_foreground_noise` as done in `perturb_with_input_noise` 

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update check and teest

Signed-off-by: stevehuang52 <heh@nvidia.com>

* fix test

Signed-off-by: stevehuang52 <heh@nvidia.com>

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
* add accepted adapter functionality into transformer, mlp and attention

Signed-off-by: arendu <adithya.r@gmail.com>

* fix to t5 adapter and ia3 evals due to predict_step dictionary key changes

Signed-off-by: arendu <adithya.r@gmail.com>

* use mixin logic for adapters in ParallelAttention and ParallelMLP classes

Signed-off-by: arendu <adithya.r@gmail.com>

* typo fix

Signed-off-by: arendu <adithya.r@gmail.com>

* updates

Signed-off-by: arendu <adithya.r@gmail.com>

* moved adapter tools

Signed-off-by: arendu <adithya.r@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix error with t5 adapter

Signed-off-by: arendu <adithya.r@gmail.com>

* updates'

Signed-off-by: arendu <adithya.r@gmail.com>

* replace ColumnParallelLinear with nn.Linear in export_utils

Signed-off-by: arendu <adithya.r@gmail.com>

* remove ColumnLinear

Signed-off-by: arendu <adithya.r@gmail.com>

* typo fix

Signed-off-by: arendu <adithya.r@gmail.com>

* update to check config targets

Signed-off-by: arendu <adithya.r@gmail.com>

* updates

Signed-off-by: arendu <adithya.r@gmail.com>

* refactor so that mixin is adapter name agnostic

Signed-off-by: arendu <adithya.r@gmail.com>

* fix merge conflict

Signed-off-by: arendu <adithya.r@gmail.com>

* minor

Signed-off-by: arendu <adithya.r@gmail.com>

* minor

Signed-off-by: arendu <adithya.r@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* using class comparison instead of string match

Signed-off-by: arendu <adithya.r@gmail.com>

* fix test fail

Signed-off-by: arendu <adithya.r@gmail.com>

* fixed checks for add_adapter

Signed-off-by: arendu <adithya.r@gmail.com>

* fixed checks for add_adapter

Signed-off-by: arendu <adithya.r@gmail.com>

Signed-off-by: arendu <adithya.r@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
…IDIA#5224)

* Change the default position of the reduction position to null and rename subsampling reduction to striding

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

* Put the caching logic outside the conformer encoder

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add description of the reduction parameters in the configs

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_asr_exportables with correct reduction position value

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
* Upgrade rnnt export for CUDA/CPU/TRT

Signed-off-by: smajumdar <titu1994@gmail.com>

* Update runtime script for onnx exported model to modern API

Signed-off-by: smajumdar <titu1994@gmail.com>

* Finalize code

Signed-off-by: smajumdar <titu1994@gmail.com>

* Remove comments

Signed-off-by: smajumdar <titu1994@gmail.com>

* Remove redundant stuff from tests

Signed-off-by: smajumdar <titu1994@gmail.com>

* Update test

Signed-off-by: smajumdar <titu1994@gmail.com>

* Remove onnx rnnt export test due to lack of onnxruntime install

Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>
Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
* update tutorials to use meeting config as default and VAD

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* update model path

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
* Incorporating Energy conditioning in FastPitch

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Minor fixes in Energy conditioning in FastPitch

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Add Energy conditioning in FastPitch to infer method

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* adding fn to function names

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Incorporating Energy conditioning in FastPitch

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Minor fixes in Energy conditioning in FastPitch

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Add Energy conditioning in FastPitch to infer method

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* adding fn to function names

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove ifelse from batching, minor refactoring changes in energy code

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Refactor based on PR comments.

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Added support for not learning alignment in energy

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Fix typo in assert statemetn

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Renaming average_pitch to average_features

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Renaming len variable name as it is a keyword

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

* Renaming len variable name as it is a keyword

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
* Hifi tts download script

Signed-off-by: Oleksii Volkovskyi <volkovskyi@berkeley.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Oleksii Volkovskyi <volkovskyi@berkeley.edu>

* comment and remove imports

Signed-off-by: Oleksii Volkovskyi <volkovskyi@berkeley.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Oleksii Volkovskyi <volkovskyi@berkeley.edu>

Signed-off-by: Oleksii Volkovskyi <volkovskyi@berkeley.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…VIDIA#5263)

* Fixed bug in transcribe_speech.py where decoding strategy was not being updated.

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add option to specify audio dropout separately for conformer encoders

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

* Add audio dropout option to test_asr_exportables

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

* Rename dropout_audio to dropout_pre_encode

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

* Update the comments in squeezeformer configs referring to conformer modules

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>

Signed-off-by: Shantanu Acharya <shantanua@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* created

* bug

Signed-off-by: Dima Rekesh <drekesh@nvidia.com>

Signed-off-by: Dima Rekesh <drekesh@nvidia.com>
Co-authored-by: Dima Rekesh <drekesh@nvidia.com>
…dels (NVIDIA#5208)

* Add Chinese TTS tokenizer and G2P.
* Add data process script.
* Add tutorial.

Signed-off-by: Yuekai Zhang <zhangyuekai@foxmail.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
* Add files for commit

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Added parallelism on p-value search

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Changed speaker clustering to accept torch.tensor

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Cleaned up the code and tested to have identical output

Signed-off-by: Taejin Park <tango4j@gmail.com>

* update on Notebook demo

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Added eigvalsh for faster eig val calculation:

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Remove NMESC_JitScriptedModule.ipynb

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Cleaned code and style fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Modified MSDD framework to fit torch-scripted clustering

Signed-off-by: Taejin Park <tango4j@gmail.com>

* LGTM fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* removed all string based timestamps

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Removed unnecessary lines

Signed-off-by: Taejin Park <tango4j@gmail.com>

* removed redundant lines

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Add enhanced speaker count back

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed minor docstrings

Signed-off-by: Taejin Park <tango4j@gmail.com>

* removed import Counter

Signed-off-by: Taejin Park <tango4j@gmail.com>

Signed-off-by: Taejin Park <tango4j@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Fixed typos

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

* Fixed cell type and tatoeba reference

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

* Fixed typo

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

* Fixed branch variable

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>
tango4j and others added 24 commits November 7, 2022 12:59
* Move arguments to forward function

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Resolved type issue

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <tango4j@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…NVIDIA#5341)

* [STT] Add stt_ru_conformer_ctc_large

Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>

* [STT] Add stt_ru_conformer_transducer_large

Add stt_ru_conformer_transducer_large

Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
Co-authored-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
* Fixing de-autocast

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Cleanup

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Refining export with max_dim/batch

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Moving cast utils to its own module

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
* fixes

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

* fixes

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

* moved `create_text_and_labels` to token_classification_utils.py

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
Co-authored-by: Dima Rekesh <drekesh@nvidia.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
…peaker sim notebook (NVIDIA#5292)

* Added rm -f command to avoid error message

Signed-off-by: Taejin Park <tango4j@gmail.com>

* removed unnecessary changes

Signed-off-by: Taejin Park <tango4j@gmail.com>

Signed-off-by: Taejin Park <tango4j@gmail.com>
…NVIDIA#5345)

* [DOC] added ipython dependency to support IPython.sphinxext extension

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* revert ipython extension in the doc and replace ipython block with
shell-session.

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
* set add_pooling_layer=False for huggingface bert model

* remove add_pooling_layer=False and set find_unused_parameters=True

* set num_prompt_tokens to 0 for huggingface

Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
* Add Gradio App to ASR Docs (NVIDIA#5270)

Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>
(cherry picked from commit e4b6a38)

* Fix issue with normalized config for dataset name

Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>
NVIDIA#5332)

* Update reinstall.sh and requirements.

* removed nemo_cv and nemo_simple_gan in reinstall.sh.
* relaxed numba version limits.
* added tensorboard requirement to avoid any incpmpatible issue.

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* revert changes for numba

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
* Global batch size support for validation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Global batch size support for bert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* bert batch support

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* bert batch size support

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* O2 support for bert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update megatron_bert_pretraining.py

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>

* Update megatron_bert_model.py

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update megatron_bert_config.yaml

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update megatron_bert_model.py

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>

* Bug fix

* Bug fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Bug fix

* Bug fix

* Bug fix

* Update megatron_bert_config.yaml

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>

* PPBert

* PPBert

* PPBert

* PPBert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update megatron_bert_config.yaml

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>

* bug fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* bug fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* bug fix

* bug fix

* bug fix

* bug fix

Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>

Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
* Enable mlflow logger

Signed-off-by: whrichd <trabeitwrq@gmail.com>

* fix style

Signed-off-by: whrichd <trabeitwrq@gmail.com>

* Add doc lines.

Signed-off-by: whrichd <trabeitwrq@gmail.com>

* change default value

Signed-off-by: whrichd <trabeitwrq@gmail.com>

* fix doc

Signed-off-by: whrichd <trabeitwrq@gmail.com>

* addressed comments, added dataclass

Signed-off-by: whrichd <trabeitwrq@gmail.com>

* fix style

Signed-off-by: whrichd <trabeitwrq@gmail.com>

* fix doc

Signed-off-by: whrichd <trabeitwrq@gmail.com>

Signed-off-by: whrichd <trabeitwrq@gmail.com>
* Add details to SDP README.md

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Add docstring to WriteManifest processor

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Add docstring to CreateInitialManifestMLS

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Add ModifyManifestTextProcessor docstring

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Add ASRInference docstring

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Add base_processor docstrings

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Add minimal SDP docs page

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Update tools/speech_dataset_processor/README.md

Co-authored-by: Igor Gitman <igitman@nvidia.com>
Signed-off-by: Elena Rastorgueva <80532067+erastorgueva-nv@users.noreply.github.com>

* Write simple README for SDP and move complex explanations to docs

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Remove incorrect type hints

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Make config example less confusing

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Fix typo

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Clarify that YAML file is config file in README

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Remove unused imports

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Remove SDP docs for now

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* Remove links to docs in SDP README

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Signed-off-by: Elena Rastorgueva <80532067+erastorgueva-nv@users.noreply.github.com>
Co-authored-by: Igor Gitman <igitman@nvidia.com>

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Signed-off-by: Elena Rastorgueva <80532067+erastorgueva-nv@users.noreply.github.com>
Co-authored-by: Elena Rastorgueva <80532067+erastorgueva-nv@users.noreply.github.com>
Co-authored-by: Igor Gitman <igitman@nvidia.com>
NVIDIA#5381)

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Co-authored-by: Elena Rastorgueva <80532067+erastorgueva-nv@users.noreply.github.com>
) (NVIDIA#5384)

Co-authored-by: Adi Renduchintala <108822655+arendu@users.noreply.github.com>
Signed-off-by: Ryan <rlangman@nvidia.com>
* [TTS] Add Spanish FastPitch training configs
* [TTS] Add single speaker Spanish configs

Signed-off-by: Ryan <rlangman@nvidia.com>
* Remove duplicated type annotations

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix tuple annotations in function return types

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Add necessary imports

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Add necessary imports

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix types in obvious places

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix types in obvious places

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix unused import (avoid quotes in type annotations)

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Revert "Fix unused import (avoid quotes in type annotations)"

This reverts commit ea433ef.

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Remove problematic import

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix list_available_models method type

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Revert some changes

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Revert quotes in list_available_models

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>

Signed-off-by: smajumdar <titu1994@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
* Add cpWER calculation feature

Signed-off-by: Taejin Park <tango4j@gmail.com>

* added notebook

Signed-off-by: Taejin Park <tango4j@gmail.com>

* updated notebook and diarization_utils

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Minor update on tutorial notebook

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Style fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update on missing docstrings

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Fixed an unfinished docstring

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Removed unused variables

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Fixed dict input to list input

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Style fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* fixed LGTM issues

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Fixed error in cpWER cal

Signed-off-by: Taejin Park <tango4j@gmail.com>

* fixed docstrings

Signed-off-by: Taejin Park <tango4j@gmail.com>

* fixed docstrings

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Fix some of the typing issues, lower case names

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Replaced bruteforce with LSA alg for cpWER

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Reflected PR comments

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Cleaned notebook

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* updated notebook

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Fixed LGTM warnings

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added test_diar_metrics.py

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed typos

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Fixed wrong type annotations

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Added bruteforce mode and its unit-test

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* LGTM issues fixed

Signed-off-by: Taejin Park <tango4j@gmail.com>

* reolve LGTM issues

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* unified speaker key in trans_dict

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removed unused variable and imports

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Update nemo/collections/asr/parts/utils/diarization_utils.py

Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>

* Update nemo/collections/asr/parts/utils/diarization_utils.py

Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>

* moved all the diarization eval to der.py

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Update tests/collections/asr/test_diar_metrics.py

Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>

* der.py update on tests

Signed-off-by: Taejin Park <tango4j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* unused imports and style fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* style fix

Signed-off-by: Taejin Park <tango4j@gmail.com>

* unused import

Signed-off-by: Taejin Park <tango4j@gmail.com>

* reflected review comments

Signed-off-by: Taejin Park <tango4j@gmail.com>

* Fixed an import bug in tutorial notebook

Signed-off-by: Taejin Park <tango4j@gmail.com>

Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2022

This pull request introduces 14 alerts and fixes 8 when merging 1d84b8d into 155f1f7 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 4 for First argument to super() is not enclosing class
  • 2 for Unused local variable
  • 1 for Signature mismatch in overriding method
  • 1 for Variable defined multiple times

fixed alerts:

  • 8 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2022

This pull request introduces 14 alerts and fixes 8 when merging 13e2732 into 155f1f7 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 4 for First argument to super() is not enclosing class
  • 2 for Unused local variable
  • 1 for Signature mismatch in overriding method
  • 1 for Variable defined multiple times

fixed alerts:

  • 8 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Signed-off-by: David <amosalla@asu.edu>
@Davood-M Davood-M merged commit 6e9a9f7 into NVIDIA:davidm/riva_transition Nov 15, 2022
@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 14 alerts and fixes 8 when merging 6b1aa75 into caf2ac4 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 4 for First argument to super() is not enclosing class
  • 2 for Unused local variable
  • 1 for Signature mismatch in overriding method
  • 1 for Variable defined multiple times

fixed alerts:

  • 8 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.