VP Fixes for converter + Config management #6698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
titu1994
changed the title
|
Verified with pp4, vp3, and tp8, pp 4, vp 4. LGTM. Thanks! |
ericharper
approved these changes
May 26, 2023
|
Yup will cherry pick |
titu1994
added a commit
that referenced
this pull request
May 26, 2023
* [Temp] VP Fixes Signed-off-by: smajumdar <titu1994@gmail.com> * Revert logging Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> (cherry picked from commit b6f46a0)
titu1994
added a commit
that referenced
this pull request
May 26, 2023
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* [Temp] VP Fixes Signed-off-by: smajumdar <titu1994@gmail.com> * Revert logging Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
yaoyu-33
pushed a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix an issue with VP parameter loading.
NOTE: this is not a complete fix for VP, bugs are still being fixed in later PRs.
Collection: [NLP]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: