Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vp fixes #6738

Merged
merged 1 commit into from
May 26, 2023
Merged

Vp fixes #6738

merged 1 commit into from
May 26, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

VP fixes cherry picked to release branch

Collection: [NLP]

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@titu1994
VP Fixes for converter + Config management (#6698)
439b658 
* [Temp] VP Fixes

Signed-off-by: smajumdar <titu1994@gmail.com>

* Revert logging

Signed-off-by: smajumdar <titu1994@gmail.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
(cherry picked from commit b6f46a0)
@titu1994 titu1994 changed the base branch from main to r1.19.0 May 26, 2023 16:13
@titu1994 titu1994 merged commit 2e2df4a into r1.19.0 May 26, 2023
@titu1994 titu1994 deleted the vp_fixes branch May 26, 2023 16:13
yaoyu-33 pushed a commit that referenced this pull request Oct 16, 2023
@titu1994 @yaoyu-33
VP Fixes for converter + Config management (#6698) (#6738)
0972fc8 
* [Temp] VP Fixes

Signed-off-by: smajumdar <titu1994@gmail.com>

* Revert logging

Signed-off-by: smajumdar <titu1994@gmail.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
(cherry picked from commit b6f46a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASR CI NLP Speaker Tasks TTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@titu1994