Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct argument order in run_online_segmentation function for get_online_subsegments_from_buffer method #9843

Closed
wants to merge 14 commits into from

Conversation

kchike
Copy link

@kchike kchike commented Jul 23, 2024

What does this PR do ?

This PR corrects the argument order in the run_online_segmentation function when calling the get_online_subsegments_from_buffer method. The previous implementation had incorrect argument ordering, which caused the method to malfunction. This fix ensures that the method works as intended.

Collection: [Note which collection this PR will affect]

Changelog

  • Corrected the argument order in the run_online_segmentation function for the get_online_subsegments_from_buffer method.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the ASR label Jul 23, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 8, 2024
kchike and others added 14 commits August 8, 2024 14:52
…et_online_subsegments_from_buffer method

Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
Signed-off-by: kchike <kchike@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* typos and branch name update to r2.0.0rc1 (NVIDIA#9846)

Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao Koluguri <nithinraok>

* restoring main branch name

Signed-off-by: Nithin Rao Koluguri <nithinraok>

---------

Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
Co-authored-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* Spectrogram transforms without torchaudio

Signed-off-by: Ante Jukić <ajukic@nvidia.com>

* Use einops, added comments

Signed-off-by: Ante Jukić <ajukic@nvidia.com>

---------

Signed-off-by: Ante Jukić <ajukic@nvidia.com>
Co-authored-by: Roman Korostik <roman.korostik@pm.me>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* add "offline" data cache generation support

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert config

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add comment for data_cache_generation_only usage

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add num_dataset_builder_threads param

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix comment

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
…VIDIA#9808)

* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
Signed-off-by: slyne deng <slyned@nvidia.com>
Co-authored-by: Slyne Deng <slynedeng@gmail.com>
Co-authored-by: slyne deng <slyned@nvidia.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* add docs

Signed-off-by: stevehuang52 <heh@nvidia.com>

* add lhotse specific info

Signed-off-by: zhehuaichen <dian.chenzhehuai@gmail.com>

* move images to github release 1.23

Signed-off-by: stevehuang52 <heh@nvidia.com>

* clean up

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: zhehuaichen <dian.chenzhehuai@gmail.com>
Co-authored-by: zhehuaichen <dian.chenzhehuai@gmail.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* Move PubMedQA example to dedicated folder

Signed-off-by: Shashank Verma <shashank3959@gmail.com>

* Add llama 3.1 SDG LoRA and NIM deployment tutorial

Signed-off-by: Shashank Verma <shashankv@nvidia.com>

* Minor updates to Llama-3.1 PEFT tutorial README

Signed-off-by: Shashank Verma <shashankv@nvidia.com>

* Minor updates to Llama 3.1 PEFT tutorial README

Signed-off-by: Shashank Verma <shashankv@nvidia.com>

* Updates to NIM deployment instructions

Signed-off-by: Shashank Verma <shashankv@nvidia.com>

* Minor update to README

---------

Signed-off-by: Shashank Verma <shashank3959@gmail.com>
Signed-off-by: Shashank Verma <shashankv@nvidia.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* Metric with Squim Objective and MOS

Signed-off-by: Ante Jukić <ajukic@nvidia.com>

* Removed utility functions

Signed-off-by: Ante Jukić <ajukic@nvidia.com>

---------

Signed-off-by: Ante Jukić <ajukic@nvidia.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
…se) (NVIDIA#9699) (NVIDIA#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* adding japanese text preprocessing
* japanese phoneme tokenizer
* japanese tests
* japanese g2p model
* japanese word to ipa dictionary
* add requirements

Signed-off-by: Alex Cui <alexcui1994@gmail.com>

---------

Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com>
Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
)

* Query TransformerConfig attributes when copying btw configs

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* test

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
* MoE docs

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* additional fixes

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants