[TRTLLM-6342][bug] Patched incorrect starcoder tp config

[greg-kwasniewski1]

Temporary patch to starcoder model, fixing incorrect tp_plan config. The config is already merged into hf huggingface/transformers#40814 , so as soon as TRT-LLM updates to the newer HF transformers repo (probably 4.57), the patch can be removed.

Summary by CodeRabbit

• Bug Fixes

  • Improved compatibility and stability for StarCoder2 models during auto-deploy, preventing errors related to tensor-parallel planning and ensuring smoother inference.

• Chores

  • Applied a temporary compatibility patch to maintain correct behavior with current transformer versions until the next upstream release.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[greg-kwasniewski1]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

Introduces an import-time patch in tensorrt_llm/_torch/auto_deploy/models/patches/starcoder.py that imports Starcoder2Config from transformers and sets Starcoder2Config.base_model_tp_plan["layers.*.mlp.c_proj"] = "rowwise". Comment notes it’s temporary until transformers >= 4.57.

Changes

Cohort / File(s)	Summary of Changes
Starcoder2 TP plan patch tensorrt_llm/_torch/auto_deploy/models/patches/starcoder.py	Added import of Starcoder2Config and mutated base_model_tp_plan at import time to set "layers.*.mlp.c_proj": "rowwise" with a temporary comment tied to HF version upgrade.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant App as Application
  participant Patch as patches/starcoder.py
  participant HF as transformers.Starcoder2Config

  App->>Patch: import starcoder patch module
  activate Patch
  Patch->>HF: import Starcoder2Config
  Patch->>HF: mutate base_model_tp_plan["layers.*.mlp.c_proj"] = "rowwise"
  deactivate Patch
  Note right of HF: Patch applied at import-time\n(temporary until HF >= 4.57)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The provided description contains a brief summary at the top but does not populate any of the required template sections—“## Description,” “## Test Coverage,” or the PR checklist fields are left as comments or unfilled placeholders—so it fails to meet the repository’s description template requirements.	Fill out the “## Description” section with a concise explanation of the issue and solution, add a “## Test Coverage” section listing relevant tests, and complete the PR checklist by removing instructional comments and marking off each item as appropriate.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “[TRTLLM-6342][bug] Patched incorrect starcoder tp config” succinctly identifies the Jira ticket, uses a bracketed type and clearly describes the primary change, making it both specific and aligned with the repository’s title conventions.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #20492 [ run ] triggered by Bot

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e107749 and 4c8a0f4.

📒 Files selected for processing (1)

• tensorrt_llm/_torch/auto_deploy/models/patches/starcoder.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

• tensorrt_llm/_torch/auto_deploy/models/patches/starcoder.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

• tensorrt_llm/_torch/auto_deploy/models/patches/starcoder.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

• tensorrt_llm/_torch/auto_deploy/models/patches/starcoder.py

🔇 Additional comments (1)

tensorrt_llm/_torch/auto_deploy/models/patches/starcoder.py (1)

1-1: Import statement is correct.

The import path correctly targets the Starcoder2Config class needed for the patch.

[tensorrt-cicd]

PR_Github #20492 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15457 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.