Add some documentation for memory_resource
#1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harrism I cannot add you to the reviewers, so here a ping |
miscco
added
feature request
|
@jrhemstad can you change it so I can be added as a reviewer? |
griwes
requested changes
Dec 19, 2023
harrism
requested changes
Dec 19, 2023
There was a problem hiding this comment.
praise: Wow, great docs with fantastic examples. I love the advice at the end.
suggestion: Since there is a lot in here, perhaps a TOC or some guide to the doc at the top would be useful?
question/suggestion: This is a great didactic document. But it is not an API reference. Is there an API reference to the concepts and refs?
nit: please correct the spelling of "documentation" in the PR title.
miscco
changed the title
memory_resourcememory_resource
harrism
requested changes
Jan 8, 2024
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
harrism
reviewed
Jan 11, 2024
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
|
@griwes you are still marked as "changes requested" could you give this another look? |
griwes
approved these changes
Jan 18, 2024
jrhemstad
reviewed
Jan 18, 2024
jrhemstad
reviewed
Jan 18, 2024
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no documentation for our memory resource design.