Skip to content

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Oct 2, 2025

This PR adds a pixi setup for cuda_pathfinder leveraging most of the existing pyproject.toml setup.

Copy link
Contributor

copy-pr-bot bot commented Oct 2, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

test_nvidia_wheels_cu12 = [
test = ["pytest>=6.2.4"]
cu12 = [
"cuda-toolkit[nvcc,cublas,nvrtc,cudart,cufft,curand,cusolver,cusparse,npp,nvfatbin,nvjitlink,nvjpeg,cccl]==12.*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does pixi handle the pypi --> conda mapping here where if using pixi does it install the pip packages or map to conda packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the pyproject.toml integration it maps only to pypi packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I think that's preferable to avoid having to maintain two lists of packages.

kkraus14
kkraus14 previously approved these changes Oct 2, 2025
@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 2, 2025

I don't think this needs to run CI, so I'll try out the new skipper functionality.

@cpcloud cpcloud changed the title dev: add pixi setup for reproducible environments dev: add pixi setup for reproducible environments [no-ci] Oct 2, 2025
@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 2, 2025

/ok to test

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 2, 2025

@kkraus14 I think this needs an approval again, because I rebased.

@cpcloud cpcloud enabled auto-merge (squash) October 2, 2025 21:22
"nvidia-nccl-cu12; sys_platform != 'win32'",
"nvidia-nvshmem-cu12; sys_platform != 'win32'",
]
test_nvidia_wheels_cu13 = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_nvidia_wheels_cu13 and test_nvidia_wheels_cu12 are referenced here:

:~/forked/cuda-python $ git grep 'test_nvidia_wheels_cu'
.github/workflows/test-wheel-linux.yml:          pip install --only-binary=:all: -v . --group "test_nvidia_wheels_cu${TEST_CUDA_MAJOR}" --group test_nvidia_wheels_host
.github/workflows/test-wheel-windows.yml:          pip install --only-binary=:all: -v . --group "test_nvidia_wheels_cu${TEST_CUDA_MAJOR}" --group test_nvidia_wheels_host
cuda_pathfinder/pyproject.toml:test_nvidia_wheels_cu12 = [
cuda_pathfinder/pyproject.toml:test_nvidia_wheels_cu13 = [
toolshed/collect_site_packages_dll_files.ps1:pip install --only-binary=:all: -e '.[test,test_nvidia_wheels_cu12,test_nvidia_wheels_host]'
toolshed/collect_site_packages_dll_files.ps1:pip install --only-binary=:all: -e '.[test,test_nvidia_wheels_cu13,test_nvidia_wheels_host]'
toolshed/collect_site_packages_so_files.sh:pip install --only-binary=:all: -e . --group test --group test_nvidia_wheels_cu12 --group test_nvidia_wheels_host
toolshed/collect_site_packages_so_files.sh:pip install --only-binary=:all: -e . --group test --group test_nvidia_wheels_cu13 --group test_nvidia_wheels_host

Do those need to be updated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Ralf was right and ignoring this caused this PR to fail on main and to be reverted. Why is [no-ci] allowed here @cpcloud @kkraus14 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an oversight on my part in reviewing. I saw the green checkmark and thought it ran through CI before being retitled to [no-ci] but I obviously misread things. Will be more careful moving forward.

@cpcloud cpcloud merged commit 868fa53 into NVIDIA:main Oct 3, 2025
13 checks passed
Copy link

github-actions bot commented Oct 3, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

leofang added a commit to leofang/cuda-python that referenced this pull request Oct 3, 2025
leofang added a commit that referenced this pull request Oct 3, 2025
@leofang
Copy link
Member

leofang commented Oct 3, 2025

Reverted in #1072.

@leofang
Copy link
Member

leofang commented Oct 9, 2025

@cpcloud I assume this is being revisited in #1090?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants