Skip to content

Fix skipping the check for nvidia-smi #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
+1 −1
Merged

Fix skipping the check for nvidia-smi #1084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cuda_core/build_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def _get_proper_cuda_bindings_major_version() -> str:
m = re.search(r"CUDA Version:\s*([\d\.]+)", out.stdout.decode())
if m:
return m.group(1).split(".")[0]
except FileNotFoundError:
except (FileNotFoundError, subprocess.CalledProcessError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: use shutil.which, since CalledProcessError can be literally any error that comes from running the command.

Not blocking the review though!

# the build machine has no driver installed
pass

Expand Down
Loading