Skip to content

Conversation

leofang
Copy link
Member

@leofang leofang commented Oct 6, 2025

Description

Close #1088.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang self-assigned this Oct 6, 2025
Copy link
Contributor

copy-pr-bot bot commented Oct 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kkraus14
Copy link
Collaborator

kkraus14 commented Oct 6, 2025

Tested locally and worked with both uv pip install --system -v -e . and pip install -v -e .

@leofang leofang added bug Something isn't working P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.core Everything related to the cuda.core module labels Oct 6, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Oct 6, 2025
@leofang
Copy link
Member Author

leofang commented Oct 6, 2025

/ok to test c97f405

This comment has been minimized.

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested: I rebuilt from scratch using -e for pathfinder, bindings, core, then ran the tests.

(I glanced through the changes but don't understand them enough to meaningfully review.)

@leofang
Copy link
Member Author

leofang commented Oct 6, 2025

(I glanced through the changes but don't understand them enough to meaningfully review.)

The tl;dr is that when implementing a custom build frontend (our build_hooks.py), we are required to implement hooks from both PEP-517 and PEP-660, the latter of which are needed for editable install. I kept it as a TODO back in #1041, hoping that no one would try to do -e before I circle back to work on this. I was wrong.

@leofang leofang enabled auto-merge (squash) October 6, 2025 19:08
@leofang leofang merged commit 8ddbb42 into NVIDIA:main Oct 6, 2025
75 checks passed
@leofang leofang deleted the fix_editable branch October 6, 2025 19:29
Copy link

github-actions bot commented Oct 6, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.core Everything related to the cuda.core module P0 High priority - Must do! packaging Anything related to wheels or Conda packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cuda-core editable install is broken

3 participants