Skip to content

[Backport] Make populating the internal symbol table thread-safe #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 18, 2025
Merged

[Backport] Make populating the internal symbol table thread-safe #836

merged 6 commits into from
Aug 18, 2025
+8,847 −8,831

Conversation

leofang
Copy link
Member

@leofang leofang commented Aug 13, 2025 •
edited
Loading

Description

xref: #835

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-project-automation github-project-automation bot moved this to Todo in CCCL Aug 13, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Aug 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Aug 13, 2025

/ok to test cd802e2

@pentschev pentschev mentioned this pull request Aug 13, 2025
Closed
@kkraus14
Copy link
Collaborator

/ok to test 66a50b7

@kkraus14
Copy link
Collaborator

/ok to test 2459e09

@kkraus14 kkraus14 changed the title [Backport] WIP: Make populating the internal symbol table thread-safe [Backport] Make populating the internal symbol table thread-safe Aug 14, 2025
@kkraus14 kkraus14 marked this pull request as ready for review August 14, 2025 02:36
@kkraus14
Copy link
Collaborator

/ok to test 58b7074

@kkraus14
Copy link
Collaborator

/ok to test 1be81a0

@leofang
Copy link
Member Author

leofang commented Aug 15, 2025

/ok to test cd45744

@leofang leofang mentioned this pull request Aug 15, 2025
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Todo to In Review in CCCL Aug 15, 2025
@leofang leofang added this to the cuda-python 13.0.1 & 12.9.2 milestone Aug 15, 2025
@leofang leofang self-assigned this Aug 15, 2025
@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Aug 15, 2025
@leofang leofang mentioned this pull request Aug 15, 2025
Merged
2 tasks
@leofang
Copy link
Member Author

leofang commented Aug 18, 2025

@pentschev confirmed that latest build works for fixing the bug encountered by RAPIDS. Merging.

@leofang leofang merged commit 491720d into NVIDIA:12.9.x Aug 18, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Aug 18, 2025
@leofang leofang deleted the symbol_lock_12x branch August 18, 2025 11:28
@pentschev
Copy link

Thanks @leofang and @kkraus14 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@leofang leofang

Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!
Projects
CCCL
Status: Done
Milestone
cuda-python 13.0.1 & 12.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@leofang @kkraus14 @pentschev