Make pathfinder add_dll_directory(), load_dependencies() side-effects more deterministic.
#855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
1 task
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
leofang
approved these changes
Aug 19, 2025
|
Copilot AI
added a commit
that referenced
this pull request
Aug 23, 2025
…and #855 Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
rwgk
added a commit
that referenced
this pull request
Aug 27, 2025
* Initial plan * Create Sphinx documentation infrastructure for cuda.pathfinder Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Fix title underline and test pathfinder documentation build Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Address all review feedback - fix references, remove unnecessary files, populate API docs Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Add cuda-pathfinder documentation link to CI doc preview Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * [pre-commit.ci] auto code formatting * Update cuda-core and cuda-bindings README to reference nv-versions.json Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Refactor pathfinder documentation based on review feedback - Remove lines 7-14 from api.rst (cuda.pathfinder automodule section) - Convert api.rst to use autosummary instead of direct autodoc directives following cuda-core pattern - Convert contribute.md to contribute.rst in ReST format - Remove _templates/main.html file as it's no longer needed - Update index.rst to reference contribute.rst instead of contribute.md Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Add release notes for cuda-pathfinder versions 1.0.0 and 1.1.0 - Created release directory structure under cuda_pathfinder/docs/source/release/ - Added 1.0.0-notes.rst with initial release highlights - Added 1.1.0-notes.rst with CTK 13.0.0 compatibility and bug fixes - Added release.rst index file to organize release notes - Updated index.rst to include release notes in navigation - Follows established documentation patterns from cuda-core and cuda-bindings Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Fix SPDX license identifiers and add 1.1.1 release notes for PRs #834 and #855 Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Restore _templates/main.html file as requested in review feedback Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Change format as requested by Leo #884 (comment) * Remove stray cuda/pathfinder/README.md URL in cuda_python/docs/source/index.rst * Rename release 1.1.1 to 1.X.Y * Add version 1.0.0 in cuda_pathfinder/docs/nv-versions.json * Remove unused cuda_pathfinder/docs/make.bat * Revert "Add version 1.0.0 in cuda_pathfinder/docs/nv-versions.json" This reverts commit d096d21. * Reduce divergence between cuda_bindings/docs/source/contribute.rst and cuda_pathfinder/docs/source/contribute.rst * New pre-commit fixes (related to PR #901) * Also remove version 1.1.0 from cuda_pathfinder/docs/nv-versions.json * Reduce cuda/pathfinder/README.md to a mere pointer to the sphinx-generated documentation. * Add the Search order section from the old README as a new section in the load_nvidia_dynamic_lib() docstring. * Leo's edits to new part of load_nvidia_dynamic_lib docstring Co-authored-by: Leo Fang <leof@nvidia.com> * Add more empty lines in load_nvidia_dynamic_lib docstring * Remove `**` around Linux, Windows (for consistency) * Fix existing (on main) pre-commit error * Add `*/docs/source/generated/` to .gitignore * Add toolshed/setup-docs-env.sh --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Leo Fang <leof@nvidia.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #821
Proactive change to improve stability in general, but also in support of
nvmathspecifically.Bump cuda-pathfinder version to
1.1.1a2Dropping boilerplate docstrings for private functions (these are more distracting than helpful).