-
Notifications
You must be signed in to change notification settings - Fork 213
[FEA]: Add a MemoryResource
which uses CUDA VMM APIs to allocate memory
#968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…orting driver enums
@benhg the IPC PR was merged, could you resolve conflicts plz? 🙂 |
Done, thanks for the reminder. |
pre-commit.ci autofix |
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @Andy-Jost's comment that it would be nice to parametrize some existing tests with using the VirtualMemoryResource, but I'm okay doing that in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Ben! Sorry I was not as responsive as I'd like for reviews. Keith told me this is ready to go. We have a number of PRs that have conflicts with each other, so what I'd do is to merge all P0 tasks for the release, and then merge this the last, to minimize conflicts. By the time we get to merge this PR, I will resolve all conflicts and rerun tests. No action is needed.
Marking this PR red only to avoid unplanned merge, again no action is needed. Much appreciated, Ben!
I am working on resolving the merge conflicts logically. |
/ok to test 6450712 |
|
…n into benjaming/vmm-allocator
/ok to test 4af54ac |
I always forget that not all NV employees can launch the CI... 😞 |
/ok to test 4af54ac |
Ben, Piotr and I discussed with Vishnu from the memory team, and confirmed that VMM is not supported by the TCC mode. I suggested Ben to skip the tests on Windows for now.. perhaps also raise a warning (or exception?) on |
/ok to test 9db04b1 |
Thanks Ben for your first contribution to cuda.core and Keith/Andy for review 🎉 |
Description
This is an implementation for #967.
Summary:
References:
NVIDIA VMM blog
CUDA Driver VMM docs
Checklist