This repository has been archived by the owner on Jan 22, 2024. It is now read-only.
Add support for cross-device volumes #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is a symlink not possible? Why must it be hardlink or copy? |
|
Symlinks are relative to the new container namespace and won't cross its boundaries. |
mvollrath
force-pushed
the
cross_volume_support
branch
2 times, most recently
from
d076226
to
28efb78
Compare
|
I've updated this based on feedback in #47 Copy fallback is now only used for |
mvollrath
force-pushed
the
cross_volume_support
branch
from
28efb78
to
4bd5e1c
Compare
Hard-linking will fail when Docker is on an alternate mount point. Fixes NVIDIA#47
|
Merged! Thanks for the PR @mvollrath |
|
Thanks, but you should remove the vim .swp file and add |
flx42
added a commit
that referenced
this pull request
Feb 24, 2016
|
Ouch, thank you for noticing! |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard-linking will fail when Docker graph is on an alternate mount point. Fallback to copy whenever it fails.
Fixes #47