Implement kernel for casting float to decimal #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
Related: NVIDIA/spark-rapids#9847 and NVIDIA/spark-rapids#10890. |
# Conflicts: # thirdparty/cudf
This reverts commit e4a1d5d. # Conflicts: # thirdparty/cudf
This reverts commit c14b199.
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
ttnghia
force-pushed
the
float_to_decimal
branch
2 times, most recently
from
8607d14
to
98f603b
Compare
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
ttnghia
force-pushed
the
float_to_decimal
branch
from
98f603b
to
90492aa
Compare
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
jlowe
previously approved these changes
Jul 25, 2024
src/test/java/com/nvidia/spark/rapids/jni/DecimalUtilsTest.java
Outdated
Show resolved
Hide resolved
Previously @thirtiseven helped with benchmarking, like this NVIDIA/spark-rapids#10917 (comment). @thirtiseven can you run such benchmark again on this please? Thanks. |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
jlowe
approved these changes
Jul 25, 2024
|
build |
|
New perf numbers:
Float type is a little slower than current code, but it runs much faster than cpu and gluten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a casting operation from floating point values to decimal values, following the rules of Apache Spark. The casting function also returns an additional boolean flag indicating if there was any failures with any input rows, leaving the caller to make decision whether to accept the result as-is or raise an exception.