this atkill handler does _not_ do what it claims. It claims to hand…
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le keyboard interrupts but that is precisely what the module is designed to not do. what this codeblock _does_ do is kill the server whenever `psiturk -s` is invoked. That's bad. `psiturk -s` should shut down its own servers if that is what the user wants to do. other code already handles shutting down the server on invocation of `exit` or `server off`. this code simply has to go.
|
🎉🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le keyboard interrupts but that is precisely what the module is designed to not do. what this codeblock does do is kill the server whenever
psiturk -sis invoked. That's bad.psiturk -sshould shut down its own servers if that is what the user wants to do. other code already handles shutting down the server on invocation ofexitorserver off. this code simply has to go.Closes #227