Update settings.rst #454
Merged
Update settings.rst #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds descriptions for setting custom qualifications in the config.txt file using whitelist_qualification_ids and blacklist_qualification_ids.
Fixes missing quotations on comma-delimited string to match the other parts of the file
|
Ah yup, thanks. I remembered and then forgot a few times that this was missing. I'm also going to change it from whitelist and blacklist to allowlist and blocklist respectively. |
|
Can you change "add" => "ad" in two places? And also clarify that the whitelist setting will mean that a worker can neither see nor accept a task for which they do not qualify? Then I can merge. On mobile rn. |
…e list controls not only who sees the ad but also who may participate.
|
Sure np. I've updated the text to hopefully be a bit clearer as well |
|
I don't see the new commit yet |
|
I tried pushing it again. Hopefully it works! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds descriptions for setting custom qualifications in the config.txt file using whitelist_qualification_ids and blacklist_qualification_ids.
I thought this feature could use a callout to make it easier for people to find the settings for custom qualifications. I'm sure the wording could use a bit of work.