Forresthopkins/DrStranges deep refactor #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lot of debug logging in this build, but everything now seems to be working correctly.
Needs to be tested
Also, it seems that "Transport" isn't a legal name for an inner enum
Managed to do it without any `synchronized` blocking
(JWS is still totally untested)
# Conflicts: # example-client/build.gradle # example-client/src/main/java/ua/naiksoftware/stompclientexample/MainActivity.java # lib/build.gradle # lib/src/main/java/ua/naiksoftware/stomp/ConnectionProvider.java # lib/src/main/java/ua/naiksoftware/stomp/OkHttpConnectionProvider.java # lib/src/main/java/ua/naiksoftware/stomp/WebSocketsConnectionProvider.java # lib/src/main/java/ua/naiksoftware/stomp/client/StompClient.java
Also cleaned up some remnants of the merge in the example client.
I'll replace these with a real example and real tests sometime soon
…ocolAndroid into forresthopkins-feature/deep-refactor # Conflicts: # lib/src/main/java/ua/naiksoftware/stomp/OkHttpConnectionProvider.java # lib/src/main/java/ua/naiksoftware/stomp/WebSocketsConnectionProvider.java # lib/src/main/java/ua/naiksoftware/stomp/client/StompClient.java
|
Thanks @forresthopkinsa and @drstranges |
|
Check that out! Nice!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More RX way