Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh Motion Update #545

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Mesh Motion Update #545

merged 3 commits into from
Jul 21, 2021

Conversation

wjhorne
Copy link
Contributor

@wjhorne wjhorne commented Jul 13, 2021

Includes full consolidation setup, Neohookean deformation, and new time stepping methodology.

@spdomin
Copy link
Contributor

spdomin commented Jul 14, 2021

I will review this tomorrow. Thanks. Wondering if you included the divU-based Jacobean entries for the standard elastic approach? I think we neglected this before.

@wjhorne
Copy link
Contributor Author

wjhorne commented Jul 15, 2021

I tried to mimic what was already in place which did have a div term. I could extend it further if it is missing something as well

@spdomin
Copy link
Contributor

spdomin commented Jul 19, 2021

Sorry, my VoF push created a new gold copy. Could you please re-bless after a pull?

@wjhorne
Copy link
Contributor Author

wjhorne commented Jul 20, 2021

It now has all recent Nalu updates and I have re-blessed the gold copies.

Copy link
Contributor

@spdomin spdomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some debug work made its way through....

@@ -630,6 +630,8 @@ OversetManagerSTK::define_background_bounding_boxes()
std::string targetNameBackground(oversetUserData_.backgroundBlock_);
stk::mesh::Part *targetPartBackground = metaData_->get_part(targetNameBackground);

std::cout << "TargetNameBackground :: " << targetNameBackground << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a WIP...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now removed.

@@ -989,6 +991,9 @@ OversetManagerSTK::create_overset_info_vec()
for (int j = 0; j < nDim_; ++j ) {
const double xj = coords[offSet+j];
theInfo->nodalCoords_[j] = xj;
if (bulkData_->identifier(node)==24154)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug output...

Copy link
Contributor Author

@wjhorne wjhorne Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is now gone.

@@ -1381,7 +1386,10 @@ OversetManagerSTK::complete_search(
if ( infoObject->bestX_ > maxTol || !(bulkData_->is_valid(elem)) ) {
NaluEnv::self().naluOutputP0() << "Sorry, constraint node for node " << bulkData_->identifier(infoObject->constraintNode_)
<< " does not have an ideal bestX; consider clipping "
<< infoObject->bestX_ << std::endl;
<< infoObject->bestX_ << " " << infoObject->nodalCoords_[0] << " "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug output...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was extremely useful for debugging and it might be good to have something like it in the future for failed overset assembly. It is removed for now.

@wjhorne wjhorne requested a review from spdomin July 20, 2021 21:38
Copy link
Contributor

@spdomin spdomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess I did code the full Jacoians for the div-term in the mesh displacement equation.

I may change the "mass" terms later to be more descriptive. However, as it stands now, it looks good to accept.

@spdomin spdomin merged commit e7d16f7 into NaluCFD:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants