-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh Motion Update #545
Mesh Motion Update #545
Conversation
I will review this tomorrow. Thanks. Wondering if you included the divU-based Jacobean entries for the standard elastic approach? I think we neglected this before. |
I tried to mimic what was already in place which did have a div term. I could extend it further if it is missing something as well |
Sorry, my VoF push created a new gold copy. Could you please re-bless after a pull? |
It now has all recent Nalu updates and I have re-blessed the gold copies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some debug work made its way through....
src/overset/OversetManagerSTK.C
Outdated
@@ -630,6 +630,8 @@ OversetManagerSTK::define_background_bounding_boxes() | |||
std::string targetNameBackground(oversetUserData_.backgroundBlock_); | |||
stk::mesh::Part *targetPartBackground = metaData_->get_part(targetNameBackground); | |||
|
|||
std::cout << "TargetNameBackground :: " << targetNameBackground << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a WIP...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now removed.
src/overset/OversetManagerSTK.C
Outdated
@@ -989,6 +991,9 @@ OversetManagerSTK::create_overset_info_vec() | |||
for (int j = 0; j < nDim_; ++j ) { | |||
const double xj = coords[offSet+j]; | |||
theInfo->nodalCoords_[j] = xj; | |||
if (bulkData_->identifier(node)==24154) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug output...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is now gone.
src/overset/OversetManagerSTK.C
Outdated
@@ -1381,7 +1386,10 @@ OversetManagerSTK::complete_search( | |||
if ( infoObject->bestX_ > maxTol || !(bulkData_->is_valid(elem)) ) { | |||
NaluEnv::self().naluOutputP0() << "Sorry, constraint node for node " << bulkData_->identifier(infoObject->constraintNode_) | |||
<< " does not have an ideal bestX; consider clipping " | |||
<< infoObject->bestX_ << std::endl; | |||
<< infoObject->bestX_ << " " << infoObject->nodalCoords_[0] << " " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug output...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was extremely useful for debugging and it might be good to have something like it in the future for failed overset assembly. It is removed for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I guess I did code the full Jacoians for the div-term in the mesh displacement equation.
I may change the "mass" terms later to be more descriptive. However, as it stands now, it looks good to accept.
Includes full consolidation setup, Neohookean deformation, and new time stepping methodology.