-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better help slash command + some other improvements #13
Conversation
To fix the broken link in README
Add myself to contributor list Increment version to 3.1.0 Relative link to LICENSE in README.MD Added funding link to package.json patched some security warnings in dependencies updated discord.js to latest version
Easier to not leak tokens during dev and testing
Hey can you reverse the license changes? I thought I did the license stuff good earlier |
Overall it looks good. Just the license commit I felt unnecessary. Thank you so much for the contribution. |
I did not change the license, only made it clearer. You say in the readme that it's licensed under ISC, but you did not have the license file. I just added the file. Without it, it's like if the project was not open source and people are not allowed to use it... |
Oh, alright thanks for PR I'll make a little change and merge it. |
@GoudronViande24 I need access to contribute to the PR. |
Hi? |
Problem fix ? |
Sorry, I did not get the notification 2 days ago. I give you access right now. |
What changes did you want to make? |
I still don't have access |
I gave rights to all maintainers of this repo If you can't make a commit, just make a pr to my fork it also works. |
Any updates about this? @NamVr |
Today for sure, sorry for the delays. |
Thank you so much @GoudronViande24! If you would like to stay in touch with me, please add me on discord @ |
Wait I just saw you merged only one commit. You should merge the entire pull request since there are some other improvements. |
I will make another pull request so it's easier for you |
See #11
See commits for more details, but here is the summary:
help
slash command so users can get help on a single commandI did some testing so it should be safe to implement this.
Happy to contribute to this project, it helped me a lot to learn about the new stuff of Discord.js v13!