Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better help slash command + some other improvements #13

Merged
merged 8 commits into from
Feb 11, 2022
Merged

Better help slash command + some other improvements #13

merged 8 commits into from
Feb 11, 2022

Conversation

GoudronViande24
Copy link
Contributor

@GoudronViande24 GoudronViande24 commented Jan 25, 2022

See #11

See commits for more details, but here is the summary:

  • Improve the help slash command so users can get help on a single command
  • Update Discord.js to latest version
  • Add the LICENSE file with detailed license and so the link in readme is no longer broken
  • Update some dependencies for security (audits)

I did some testing so it should be safe to implement this.

Happy to contribute to this project, it helped me a lot to learn about the new stuff of Discord.js v13!

GoudronViande24 and others added 7 commits January 25, 2022 12:53
To fix the broken link in README
Add myself to contributor list
Increment version to 3.1.0
Relative link to LICENSE in README.MD
Added funding link to package.json
patched some security warnings in dependencies
updated discord.js to latest version
Easier to not leak tokens during dev and testing
@NamVr
Copy link
Owner

NamVr commented Jan 26, 2022

Hey can you reverse the license changes? I thought I did the license stuff good earlier

@NamVr NamVr self-assigned this Jan 26, 2022
@NamVr NamVr marked this pull request as draft January 26, 2022 04:52
@NamVr
Copy link
Owner

NamVr commented Jan 26, 2022

Overall it looks good. Just the license commit I felt unnecessary. Thank you so much for the contribution.

@NamVr NamVr mentioned this pull request Jan 26, 2022
@GoudronViande24
Copy link
Contributor Author

I did not change the license, only made it clearer. You say in the readme that it's licensed under ISC, but you did not have the license file. I just added the file. Without it, it's like if the project was not open source and people are not allowed to use it...

@NamVr
Copy link
Owner

NamVr commented Jan 26, 2022

Oh, alright thanks for PR I'll make a little change and merge it.

@GoudronViande24 GoudronViande24 marked this pull request as ready for review January 26, 2022 15:30
@NamVr
Copy link
Owner

NamVr commented Jan 26, 2022

@GoudronViande24 I need access to contribute to the PR.

@NamVr
Copy link
Owner

NamVr commented Jan 28, 2022

Hi?

@Mioultigaming
Copy link

Problem fix ?

@GoudronViande24
Copy link
Contributor Author

Sorry, I did not get the notification 2 days ago.

I give you access right now.

@GoudronViande24
Copy link
Contributor Author

What changes did you want to make?

@Mioultigaming
Copy link

#12 <- Can anyone help me with this problem please? -> #12

@NamVr
Copy link
Owner

NamVr commented Jan 29, 2022

Sorry, I did not get the notification 2 days ago.

I give you access right now.

I still don't have access

@GoudronViande24
Copy link
Contributor Author

Sorry, I did not get the notification 2 days ago.

I give you access right now.

I still don't have access

I gave rights to all maintainers of this repo

If you can't make a commit, just make a pr to my fork it also works.

@GoudronViande24
Copy link
Contributor Author

Any updates about this? @NamVr

@NamVr
Copy link
Owner

NamVr commented Feb 10, 2022

Today for sure, sorry for the delays.

@NamVr NamVr merged commit 9ae692c into NamVr:master Feb 11, 2022
NamVr added a commit that referenced this pull request Feb 11, 2022
@NamVr
Copy link
Owner

NamVr commented Feb 11, 2022

Thank you so much @GoudronViande24! If you would like to stay in touch with me, please add me on discord @ allroundernaman#3915 or https://discord.gg/N7AJFYf8EP (Support Server). ❤️

@GoudronViande24
Copy link
Contributor Author

Wait I just saw you merged only one commit. You should merge the entire pull request since there are some other improvements.

@GoudronViande24
Copy link
Contributor Author

I will make another pull request so it's easier for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants