Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to tutorial on dipole sources in cylindrical coordinates #2483

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Apr 24, 2023

Two main improvements to the recent Tutorial/Nonaxisymmetric Dipole Sources:

  1. Mention that for simulation of a dipole at $r = 0$, only a single $\hat{r}$-polarized point source is necessary rather than a combination of $\hat{r}$ and $\hat{\phi}$ sources as would be expected theoretically. See also #2452 (comment).
  2. In the simulation script, rather than perform $M$ simulations where $M$ is determined analytically as $kr$, perform as many simulations as necessary until the radiated flux has decreased by some threshold relative to its maximum value. This modification improves the convergence of the results since internal testing has revealed that using a predetermined $M$ may truncate the expansion too early and therefore produce inaccurate results.

Also includes some minor fixes and improvements to the rest of the text and script.

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
@codecov-commenter
Copy link

Codecov Report

Merging #2483 (3832e84) into master (845cdf4) will increase coverage by 0.57%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
+ Coverage   73.25%   73.82%   +0.57%     
==========================================
  Files          17       17              
  Lines        5212     5269      +57     
==========================================
+ Hits         3818     3890      +72     
+ Misses       1394     1379      -15     

see 1 file with indirect coverage changes

@oskooi oskooi merged commit d0d81bb into NanoComp:master Apr 28, 2023
@oskooi oskooi deleted the cyl_dipole_fixes branch April 28, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants