-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress tests for partial page load #1605
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1605 +/- ##
=========================================
Coverage 70.58% 70.58%
Complexity 1647 1647
=========================================
Files 32 32
Lines 4321 4321
=========================================
Hits 3050 3050
Misses 1271 1271 ☔ View full report in Codecov by Sentry. |
37d666f
to
c1db580
Compare
c1db580
to
315b40d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I'm wondering if mappings should be checked on vocab home page too.
Quality Gate failedFailed conditions |
@UnniKohonen I added tests for mappings as well. All good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reasons for creating this PR
This PR adds more Cypress tests for verifying functionality during and after partial page loads.
Link to relevant issue(s), if any
Description of the changes in this PR
const SKOSMOS
towindow.SKOSMOS
, and all references to it towindow.SKOSMOS
(this makes it accessible on the Cypress side)window.SKOSMOS
has been properly updated after partial page loadKnown problems or uncertainties in this PR
Cypress/Electron appears to have problems getting stuck with
cy.visit(url)
in case the URL has already been loaded by the tested application using AJAX style requests. The code in the PR avoids this situation by using different example concept pages for the partial page load tests than for the subsequent tests that perform full page loads. See this comment for some details.Checklist
.sr-only
class, color contrast)