Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing composer.lock and .phar #57

Closed
wants to merge 1 commit into from
Closed

Removing composer.lock and .phar #57

wants to merge 1 commit into from

Conversation

danmichaelo
Copy link
Contributor

  • composer.lock should not be under version control
  • composer.phar should not be part of this repo, it has its own

- composer.lock should not be under version control
- composer.phar should not be part of this repo, it has its own
@osma
Copy link
Member

osma commented Aug 29, 2014

Thanks for your issue report and pull request.

However, this is not so straightforward...

  1. Composer documentation recommends that you put composer.lock into version control. But I realize there are other opinions about this.
  2. You're right that composer.phar has its own repo, it's just convenient to have it available as a file in the repo instead of having to download it using wget or curl each time.

I have to think about is. Before composer.lock can be removed from the repo, some library versions may have to be better specified so they won't suddenly get upgraded into incompatible versions.

@danmichaelo
Copy link
Contributor Author

No prob. I wasn't aware that the Composer documentation recommends to include the .lock file. I'm so used to repos not including the .lock file, and it makes some sense if semantic versioning is used properly, but seems like it's not as straightforward as I thought.

Appreciate if you give it a thought, but I don't mind if you choose to reject the pull request. Seems like there are legitimate reasons to do so, and this is a minor-importance request anyways :)

@osma osma added this to the Next Tasks milestone Sep 18, 2014
@osma
Copy link
Member

osma commented Sep 18, 2014

It's too late to do this for the upcoming 0.5 release, but for 0.6 we could use a smarter Composer configuration.

@osma osma modified the milestones: Next Tasks, 0.6 Sep 24, 2014
osma added a commit that referenced this pull request Sep 24, 2014
… remove composer.lock from repo, as suggested by issue #57
@osma osma self-assigned this Sep 24, 2014
@osma
Copy link
Member

osma commented Oct 28, 2014

Finally removed composer.phar in commit 8e8d1e1 and updated the documentation in the wiki (install/upgrade) to reflect this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants