Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Stark logo causes error in Edge and IE due to embedded font-face #1115

Closed
christophercr opened this issue Feb 4, 2019 · 3 comments
Closed

Comments

@christophercr
Copy link
Collaborator

christophercr commented Feb 4, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

In Internet Explorer the following error is shown in the console:

CSS3114: @font-face failed OpenType embedding permission check. Permission must be Installable.
Q4VhAPMA0GCSqGSIb3DQEBAQUABIGAHcF3ia6bbyLja+VF2k6RQPCf7zsfJ0pWrDr9qJRqfPecwX97k2BOG8QrV5WUyxbhmmcz0SspE8jsvrxZsQOkKZnsHYiZJId3D5vKFPvU1ElMdA7IPS5vIMkDzejlD9AhObNWGdX7rL2sqTi9sNUMo9ljrbCVtGhYw+LXKf+RpMcAAA==

In Edge, the same error is shown but it is even more verbose :s

This is in fact the embedded font face in the Stark logo (stark_logo_transparent.svg).

Expected behavior

No errors related to font-face in the Stark logo should be logged in IE nor Edge.
Ideally we should vectorize the font instead of defining a new base64 font-face.

Minimal reproduction of the problem with instructions

  • run the showcase locally: npm run showcase
  • open the app in Edge or Internet Explorer
  • wait for the app to initialize and then open the console. The error will be logged in there.

What is the motivation / use case for changing the behavior?

Cross-browser compatibility.

Environment


Stark version: 10.0.0-beta.2


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [X] IE version 11
- [X] Edge version 16
@carlo-nomes
Copy link
Collaborator

carlo-nomes commented Feb 5, 2019

@christophercr @SuperITMan what do you think about these?
dark
light

@carlo-nomes
Copy link
Collaborator

carlo-nomes commented Feb 5, 2019

dark
light

carlo-nomes added a commit that referenced this issue Feb 7, 2019
  - small refactor

CLOSES ISSUE: #1115
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 7, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 8, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 8, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 8, 2019
@christophercr
Copy link
Collaborator Author

Closed in #1126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants