Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuBar improvements #131

Merged
merged 8 commits into from
Nov 14, 2024
Merged

MenuBar improvements #131

merged 8 commits into from
Nov 14, 2024

Conversation

simonhamp
Copy link
Member

@simonhamp simonhamp commented Nov 14, 2024

Currently, MenuBar windows are limited in what they're capable of:

  • Some settings can't be changed once they've been created, such as the icon.
  • The window itself doesn't have the same controls as other windows (e.g. they are always user-resizable and can't be made a fixed size).
  • Some features aren't exposed, such as tooltip text.
  • The window doesn't receive any events from Electron or Laravel, making it impossible to use our Native events in JS or Livewire.
  • Context menus or MenuBar windows are the only option, there's no support for custom logic.

This PR aims to fix all of these issues. It also defaults to preloading the window (when there is one) so that it is visible much sooner after the user clicks on the icon, making for a much better UX.

@simonhamp simonhamp merged commit 6ee19ca into main Nov 14, 2024
5 of 10 checks passed
@simonhamp simonhamp deleted the feature/menubar-improvement branch November 14, 2024 18:13
@SRWieZ
Copy link
Contributor

SRWieZ commented Nov 15, 2024

Awesome! Excited to try white this new PR 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants