[Bug] Vendor directory cleanup failing - Causing build notary failures

[PeteBishwhip]

What were you trying to do?

Trying to build a developer-signed and notarised app in beta.2 fails due to files that should be cleared out still being present. It causes the notary services to return an Invalid status.

An issue example is provided below. The files reporting issues should not be present within the app.

Workaround

Downgrade to v1.0.0-beta.1

What happened?

I can build apps without notarisation. If I include notarisation env vars and it attempts to, it'll fail with issues like the following:

    {
      "severity": "error",
      "code": null,
      "path": "My App.zip/My App.app/Contents/Resources/app.asar.unpacked/resources/app/vendor/nativephp/php-bin/bin/mac/x86/php-8.1.zip/php",
      "message": "The binary is not signed.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    }

How to reproduce the bug

Install version 1.0.0-beta.2
Add valid Apple Developer details to your env file
Run native:build

Package Versions

{
    "installed": [
        {
            "name": "nativephp/electron",
            "direct-dependency": true,
            "homepage": "https://github.com/nativephp/electron",
            "source": "https://github.com/NativePHP/electron/tree/1.0.0-beta.2",
            "version": "1.0.0-beta.2",
            "description": "Electron wrapper for the NativePHP framework.",
            "abandoned": false
        },
        {
            "name": "nativephp/laravel",
            "direct-dependency": false,
            "homepage": "https://github.com/nativephp/laravel",
            "source": "https://github.com/NativePHP/laravel/tree/1.0.0-beta.2",
            "version": "dev-main 0102a92",
            "description": "Laravel wrapper for the NativePHP framework.",
            "abandoned": false
        },
        {
            "name": "nativephp/php-bin",
            "direct-dependency": false,
            "homepage": "https://nativephp.com",
            "source": "https://github.com/NativePHP/php-bin/tree/0.5.6",
            "version": "0.5.6",
            "description": "PHP binaries used by the NativePHP framework",
            "abandoned": false
        }
    ]
}

PHP Version

8.3.17

Laravel Version

11.44.0

Node Version

22.11.0

Which operating systems have you seen this occur on?

macOS

OS version

MacOS Seqouia

Notes

No response

[gwleuverink]

Some additional context:

The build cleaning seems to work as intended.
Rather the removed nativephp/php-bin directory is reinstalled when dev dependencies are pruned from the build.

It must be noted that if the php-bin directory is not moved, but only the binary zips this will most likely fix the problem, as composer will not reinstall in that case.

I propose a expanded second pass of the globs in the exclude list as a last step before handing the app over to electron-builder.

Let’s merge the hotfix asap. I’ll address this as soon as I can. Unless someone beats me to it :)