Update composer.json #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it 7.3 For some modern users
milwad-dev
reviewed
Jul 22, 2023
|
It was 8.2 initially and you changed it to 8.1 hope it won't have any
effect on the source code
…On Sat, Jul 22, 2023, 11:17 AM Milwad ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In composer.json
<#42 (comment)>:
> @@ -16,7 +16,7 @@
}
],
"require": {
- "php": "^8.1",
https://github.com/illuminate/contracts/blob/master/composer.json#L17
—
Reply to this email directly, view it on GitHub
<#42 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3DHPXFKJ5BHORCFNAI3TI3XROSD3ANCNFSM6AAAAAA2TRLJCI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
If you look at @driesvints PR, you can see Laravel 11.x support PHP 8.2, now Laravel 10.x work with PHP 8.1 |
|
Okay so we are working with Laravel 10
…On Sat, Jul 22, 2023, 11:29 AM Milwad ***@***.***> wrote:
If you look at @driesvints <https://github.com/driesvints> PR, you can
see Laravel 11.x support PHP 8.2, now Laravel 10.x work with PHP 8.1
***@***.***
<illuminate/contracts@e81b816>
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3DHPXFUNMZNEACLYVRRVTTXROTSBANCNFSM6AAAAAA2TRLJCI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I was a actually going through c# windows form Nd was thinking of
implementing some properties like that will that be okay?
…On Sat, Jul 22, 2023, 11:29 AM Milwad ***@***.***> wrote:
If you look at @driesvints <https://github.com/driesvints> PR, you can
see Laravel 11.x support PHP 8.2, now Laravel 10.x work with PHP 8.1
***@***.***
<illuminate/contracts@e81b816>
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3DHPXFUNMZNEACLYVRRVTTXROTSBANCNFSM6AAAAAA2TRLJCI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
There are code features here which require PHP 8.1. Also PHP 7.3 is well past its end of life, so we won't be supporting that |
|
Okay interesting!!
Concerning the c# windows form features
…On Sat, Jul 22, 2023, 11:37 AM Simon Hamp ***@***.***> wrote:
Closed #42 <#42>.
—
Reply to this email directly, view it on GitHub
<#42 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3DHPXHK6OGTYMDPRN5O7PDXROUO3ANCNFSM6AAAAAA2TRLJCI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No response
On Sat, Jul 22, 2023, 11:39 AM Nwinyinya David ***@***.***>
wrote:
… Okay interesting!!
Concerning the c# windows form features
On Sat, Jul 22, 2023, 11:37 AM Simon Hamp ***@***.***>
wrote:
> Closed #42 <#42>.
>
> —
> Reply to this email directly, view it on GitHub
> <#42 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3DHPXHK6OGTYMDPRN5O7PDXROUO3ANCNFSM6AAAAAA2TRLJCI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
I am getting this error when am trying to use the composer require
nativephp/electron
On Sat, Jul 22, 2023 at 12:04 PM Nwinyinya David <
***@***.***> wrote:
… No response
On Sat, Jul 22, 2023, 11:39 AM Nwinyinya David <
***@***.***> wrote:
> Okay interesting!!
> Concerning the c# windows form features
>
> On Sat, Jul 22, 2023, 11:37 AM Simon Hamp ***@***.***>
> wrote:
>
>> Closed #42 <#42>.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#42 (comment)>, or
>> unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/A3DHPXHK6OGTYMDPRN5O7PDXROUO3ANCNFSM6AAAAAA2TRLJCI>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made The version for the composer.json require key to "^7.3" instead of 8.1