Skip to content

Fixed invalid $PATH reference to $ANDROID_HOME #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

A-Lawrence
Copy link

When following the installation steps, noticed that the Android SDK paths weren't configured correctly, and then spotted this incorrect reference in the paths.

@shanerbaner82
Copy link
Contributor

When following the installation steps, noticed that the Android SDK paths weren't configured correctly, and then spotted this incorrect reference in the paths.

Take a look at the official Android Studio docs, do you interpret this differently?

Also, you stated you "noticed that the Android SDK paths weren't configured correctly", where did you notice this please?

@PeteBishwhip PeteBishwhip added the question Further information is requested label May 9, 2025
@simonhamp
Copy link
Member

The docs explicitly state this:

ANDROID_SDK_ROOT, which also points to the SDK installation directory, is deprecated.

@simonhamp simonhamp closed this May 22, 2025
@A-Lawrence
Copy link
Author

A-Lawrence commented May 23, 2025

@shanerbaner82 @simonhamp fair point on both, however there's still a PR to be had here on the basis that my original intent was to update the usage of the defined environment variable, rather than the definition itself.

CleanShot 2025-05-23 at 21 46 02

In which case, are we in agreement that the line export ANDROID_SDK_ROOT=$HOME/Library/Android/sdk should actually be export ANDROID_HOME=$HOME/Library/Android/sdk ?

@A-Lawrence
Copy link
Author

A-Lawrence commented May 23, 2025

Just saw this PR opened, so referencing it here also: @152

@michaelishri
Copy link
Contributor

michaelishri commented May 25, 2025

My apologies, I didn't see this had already been discussed and closed. Should I pull my PR #152?

I guess in the end, the docs need to be updated either way ($ANDROID_HOME or $ANDROID_SDK_ROOT). I wasn't sure which one was correct so just chose $ANDROID_SDK_ROOT. Happy to make it $ANDROID_HOME if its preferred.

@michaelishri
Copy link
Contributor

michaelishri commented May 25, 2025

Oh yeah, looking at the Android docs then asking Gemini, it looks like $ANDROID_HOME is the recommended option.

Have updated my PR with the changes, but let me know if you want me to cancel it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants