Skip to content

Implement non uniform border corner radiuses and fix blinking image-view radiuses #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 27, 2017
Merged

Implement non uniform border corner radiuses and fix blinking image-view radiuses #4573

merged 6 commits into from
Jul 27, 2017

Conversation

PanayotCankov
Copy link
Contributor

No description provided.

@PanayotCankov PanayotCankov mentioned this pull request Jul 19, 2017
Closed
@PanayotCankov
Copy link
Contributor Author

uitests

@vchimev
Copy link
Contributor

vchimev commented Jul 21, 2017

widgets-uitests-android

@vchimev
Copy link
Contributor

vchimev commented Jul 21, 2017

widgets

@vchimev
Copy link
Contributor

vchimev commented Jul 21, 2017

ci/jenkins/widgets (unit tests) are good
ci/jenkins/widgets-uitests-android:
http://nsbuild01.telerik.com/build/job/tns-modules-widgets-PR-uitests-android/22/artifact/functional-tests/target/surefire-reports/html/index.html

@PanayotCankov
Copy link
Contributor Author

widgets-uitests-android

@PanayotCankov
Copy link
Contributor Author

widgets

@SvetoslavTsenov
Copy link
Contributor

#4521

@PanayotCankov
Copy link
Contributor Author

widgets-uitests-android

@PanayotCankov PanayotCankov mentioned this pull request Jul 24, 2017
Closed
@SvetoslavTsenov
Copy link
Contributor

widgets-uitests-android

@SvetoslavTsenov
Copy link
Contributor

run ci

@SvetoslavTsenov
Copy link
Contributor

uitests

@PanayotCankov
Copy link
Contributor Author

widgets-uitests-android

@PanayotCankov
Copy link
Contributor Author

uitests

@PanayotCankov PanayotCankov mentioned this pull request Jul 26, 2017
Closed
@SvetoslavTsenov
Copy link
Contributor

Hey @PanayotCankov
It seems that the fix is fine.
I need to know what do you think about these two images for iOS
http://nsbuild01.telerik.com/build/job/tns-modules-PR-uitests-ios/325/artifact/functional-tests/target/surefire-reports/screenshots/button_border_08_actual.png
http://nsbuild01.telerik.com/build/job/tns-modules-PR-uitests-ios/325/artifact/functional-tests/target/surefire-reports/screenshots/button_border_08_expected.png

As far as for android the tests look fine
http://nsbuild01.telerik.com:8080/build/view/PR/job/tns-modules-widgets-PR-uitests-android/46/artifact/functional-tests/target/surefire-reports/html/index.html

@SvetoslavTsenov
Copy link
Contributor

cuteness

@SvetoslavTsenov
Copy link
Contributor

cuteness ios

@SvetoslavTsenov
Copy link
Contributor

cuteness android

@SvetoslavTsenov
Copy link
Contributor

animations

@PanayotCankov PanayotCankov merged commit 4365979 into master Jul 27, 2017
@PanayotCankov PanayotCankov deleted the image-and-corners branch August 22, 2017 06:57
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@vakrilov vakrilov vakrilov approved these changes

@hshristov hshristov hshristov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PanayotCankov @vchimev @SvetoslavTsenov @vakrilov @hshristov @ns-bot