-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(android): FlexboxLayout support for isPassThroughParentEnabled #8798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NathanaelA I managed to run sample locally and correct all possible ui-tests app issues. I commited new changes, hope I didn't cause any inconvenience. |
Nice work @dimitrisrk thank you. Possible to just resolve those 2 conflicts listed and then we could get this in. Everyone greatly appreciates your efforts 🤗 |
Thank you very much, it's a pleasure having a chance to help. This PR was redone anew on NS 7 branch, so we might be talking about very small conflicts. |
8753605
to
86395da
Compare
d4ced42
to
53488b5
Compare
I see there is trouble adapting this since paths for conflicting files have changes. |
# Conflicts: # apps/ui/app/flexbox/flexbox-ispassthroughparent.ts # apps/ui/app/flexbox/flexbox-ispassthroughparent.xml # apps/ui/src/flexbox/flexbox-ispassthroughparent-page.ts # apps/ui/src/flexbox/flexbox-ispassthroughparent-page.xml # apps/ui/src/flexbox/flexbox-ispassthroughparent.ts # apps/ui/src/flexbox/flexbox-ispassthroughparent.xml
@NathanWalker I tried few attempts to rebase and think I got rid of these conflicts. |
@NathanWalker @rigor789 Thank you for examining and merging this. Java class has more than 1 constructors which might be unused because TypeScript class instantiates a nativeView using constructor with a single argument. https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/layouts/flexbox-layout/index.android.ts#L91 |
PR Checklist
What is the current behavior?
When setting 'isPassThroughParentEnabled' property to FlexboxLayout, a exception is thrown.
What is the new behavior?
Property 'isPassThroughParentEnabled' will work for FlexboxLayout.
Fixes/Closes #8567 .