Webview Crash With Android 8.1.0 / Chromium 67.0.3396.68

[sud80]

Did you verify this is a real problem by searching the NativeScript Forum
https://discourse.nativescript.org/t/webview-causes-app-crash-on-android-with-chrome-67-release/6202

Tell us about the problem
With the latest chrome (67.0.3396.68) update on Android 8.1.0 webview is crashing.

Please provide the following version numbers that your issue occurs with:

• CLI: 3.4.2
• tns-android: 3.4.2
• Android: 8.1.0
• Chromium: 67.0.3396.68

After further debugging,
Invoking of onReceivedError on webviewclient is causing the null pointer exception in Runtime.java (https://github.com/NativeScript/android-runtime/blob/v3.4.2/test-app/runtime/src/main/java/com/tns/Runtime.java), Line number 682: (String pname = p.getName();)

After the chrome update on the device, the 2nd(android.webkit.WebResourceRequest) and 3rd (android.webkit.WebResourceError) parameters of function onReceivedError of WebViewClient received object whose class is having empty package. This causes line 679 of https://github.com/NativeScript/android-runtime/blob/v3.4.2/test-app/runtime/src/main/java/com/tns/Runtime.java [clazz.getPackage();] to return null. And subsequently this causes null pointer exception on line 682 of same file [ String pname = p.getName(); ] .

Printing the class names inside the function getTypeMetadata, with latest chrome as webview, gives class vS, class vR.

But in the device if I select to use android webview instead of chrome webview, it gives class as com.android.webview.chromium.xz, com.android.webview.chromium.WL.

So essentially the function getTypeMetadata is not handling classes with empty packages.
So instaed of:

Package p = (mostOuterClass != null)
                    ? mostOuterClass.getPackage()
                    : clazz.getPackage();
int packageCount = 1;
String pname = p.getName();

changing to:

Package p = (mostOuterClass != null)
                    ? mostOuterClass.getPackage()
                    : clazz.getPackage();
int packageCount = p != null ? 1 : 0;
String pname = p != null ? p.getName() : "";

This seems to be fixing the issue.

[erjdriver]

I'm running into a similar crash if the url one is visiting is redirected.

The problem seems to do with the latest Chrome update and happens on Android 7.0 also.

If I go with an older version of Chrome - works fine.

This is with tns android 4.1.1

Is there a file I can modify to get this fixed?

`An uncaught Exception occurred on "main" thread.
com.tns.NativeScriptException: Java Error!
at com.tns.Runtime.callJSMethodNative(Native Method)
at com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1100)
at com.tns.Runtime.callJSMethodImpl(Runtime.java:982)
at com.tns.Runtime.callJSMethod(Runtime.java:969)
at com.tns.Runtime.callJSMethod(Runtime.java:953)
at com.tns.Runtime.callJSMethod(Runtime.java:945)
at com.tns.gen.android.webkit.WebViewClient_view_15_32_WebViewClientImpl.shouldOverrideUrlLoading(WebViewClient_view_15_32_WebViewClientImpl.java:25)
at yk.b(PG:89)
at org.chromium.android_webview.AwContentsClientBridge.shouldOverrideUrlLoading(PG:172)
at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
at org.chromium.base.SystemMessageHandler.handleMessage(PG:9)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6692)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1468)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Package.getName()' on a null object reference
at com.tns.Runtime.getTypeMetadata(Runtime.java:694)
at com.tns.Runtime.getTypeMetadata(Runtime.java:672)
... 17 more

`

[sud80]

@erjdriver the fix I have said in the first post should take care of this as well. For us also it was happening on shouldOverrideUrlLoading as well but on android 8.1.
I am surprised it is happening in Android 4.1.1 as well. What is the webview and chrome version?

If you want to try the fix locally:
You can clone the project, make the above said change, build the project locally (https://github.com/NativeScript/android-runtime/#how-to-build), install the newly built directory as your android platform (tns platform add android --framework-path )

[erjdriver]

Thanks for the quick response.

Chrome 67.0.3396.68

Not sure about webview - my understanding is Chrome disables the installed webview.

I don't have the setup to do a local build - I hope these guys fix it asap.

Is there a change I can make in javascript from within Code editor - that'll fix this . I don't have the Android Studio etc installed.

Thanks for reporting.

[sud80]

@erjdriver are you sure the android version is 4.1.1? The chrome 67.0.3396.68 was not available when I checked below android 8.1.

As far as I understand, I don't think you can fix this from javascript side as the issue happens during a javascript call from native side.

[erjdriver]

I'm using tns android platform version 4.1.1

The Android version on my device is 7.0

My Chrome version is the same that's on the title of this thread.

[mspusta78]

I am having same issue. I tested Android 7.0 and 8.1.0 and the issues occurs when Chrome 67 is installed.
What can we do with productions apps that are crashing?
Is there a fix for this?

[erjdriver]

I believe the solution is provided by @sud80 above - requires you cloning and building the android module on your pc.

Other is to wait for it to be fixed by NS.

[mspusta78]

Is there a way to downgrade back to Chrome 66 ?

…

On Mon, Jun 4, 2018 at 3:10 PM, erjdriver ***@***.***> wrote: I believe the solution is provided by @sud80 <https://github.com/sud80> above - requires you cloning and building the android module on your pc. Other is to wait for it to be fixed by NS. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1075 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgM3s4P7jbSskSuSOILU0CaJMXeD-SFZks5t5YY2gaJpZM4UYkzZ> .

[Guatom]

@mspusta78, only unsafe methods as far as I know, you have to get the old APK and manually install it.

[surdu]

You can "uninstall" Chrome to fix the issue. It will downgrade Chrome to the factory version, but it fixes the problem until we have the NS fix.

[mspusta78]

@erjdriver I was able to clone the android module app but I am having hard time building it and I am not sure how to use it in my project. @sud80 sud80 Any insight or steps on how to do it?

[sud80]

@mspusta78

1. Clone the project
2. make the above said change
3. build the project locally (https://github.com/NativeScript/android-runtime/#how-to-build). Follow the instructions in the link. Make sure you have android sdk's and tool's installed. (I have android studio from which I manage the sdks installed). You need to specifically have the NDK from the tools also installed. This will create the build in the dist directory.
4. install the newly built runtime as your android platform
   command: tns platform add android --framework-path path_to_dist_directory
5. build your app as usual. At this step it might be possible that your build is failing due to NDK tool installed.
   A problem occurred starting process 'command '/mypath/android-sdk/ndk-bundle/toolchains/mips64el-linux-android-4.9/prebuilt/darwin-x86_64/bin/mips64el-linux-android-strip''
   In such case, as temporary measure, just remove the tool directory either by unclicking in the android studio or by just moving the directory (/mypath/android-sdk/ndk-bundle/) out. You can again move back or install the ndk back when you need to build the android runtime.

Hope this helps.

[vtrifonov]

Thanks for reporting and looking into this @sud80. I've applied the proposed changes and it's now on PR. We'll create a patch for this as long as it's ready.

Meanwhile here's how you can easily debug the android runtime in your own project.