Extend is not working as previous versions in all cases.

[atanasovg]

From @Stavanger75 on July 5, 2016 21:39

Platform : Android. (not tested on IOS)

CLI : 2.1.0
tns-core-modules : 2.1.0
android : 2.1.1
plugins: nativescript-google-maps-sdk: 1.3.2

Extend is working great for UrlTileProvider in both android version 1.7.1 and 2.1.1
Extend TileProvider is only working for android version 1.7.1.

Complete sample code working on android version 1.7.1. can be found here:
https://github.com/Stavanger75/googlemapsdemo.

The extend code is located here :
https://github.com/Stavanger75/googlemapsdemo/blob/master/node_modules/nativescript-google-maps-sdk/map-view.android.js

Or you can use the sample code for the from the "nativescript-google-maps-sdk" plugin and just add the extend code : https://github.com/dapriett/nativescript-google-maps-sdk

Here is code that fails on android version 2.1.0 (but works on 1.7.1)

 var mapReadyCallback = new com.google.android.gms.maps.OnMapReadyCallback({
            onMapReady: function (gMap) {
                var owner = that.get();
                owner._gMap = gMap;


                /* Start custom tileprovider*/
                try{
                    var tileProvider = com.google.android.gms.maps.model.TileProvider.extend({

                        getTile: function(x,y,z){
                             console.log("Tile requested from custom tileProvider");

                            // return your custom tile here.
                            return null;
                        }
                    });

                     gMap.addTileOverlay(new com.google.android.gms.maps.model.TileOverlayOptions().tileProvider(new tileProvider()));

                }
                catch(e){
                    alert(e);
                }
});

Copied from original issue: NativeScript/NativeScript#2422

[slavchev]

@Stavanger75

The documented syntax for implementing Java interfaces uses new keyword. However, in the previous versions we inadvertently exposed extend syntax as well. Since 2.1 we did some changes that break the extend syntax.

After a short discussion with the team we decided to provide support for extend syntax for the next release. We think it will be a good for the developer productivity as otherwise you should consult with the API docs whether com.google.android.gms.maps.model.TileProvider is an interface or a class. Having common extend syntax will solve this issue. Meanwhile you can use the documented syntax.

[Stavanger75]

Hi @slavchev ,

Thans so much for adding the support for extend on interface in 2.2.0 .

I have problem using the new keyword in Android 2.1.1 also. It is working fine on Android 1.7.1.
After it fails i have to remove android and add it again to get the application running:

• tns platform remove android
• tns platform add android

Here is the code i have tested:

/* Start custom tileprovider interface*/

            try{

                var tileProviderInterface = new com.google.android.gms.maps.model.TileProvider({

                    getTile: function(x,y,z){
                        console.log("Tile requested from custom tileProvider intface implementation");

                        // return your custom tile here.
                        return null;
                    }

                });

                gMap.addTileOverlay(new com.google.android.gms.maps.model.TileOverlayOptions().tileProvider(tileProviderInterface));

            }
            catch(e){
                alert(e);
            }

[slavchev]

Hi @Stavanger75

The code should be something like the following

 var tileProvider = new com.google.android.gms.maps.model.TileProvider({
                        getTile: function(x,y,z){
                             console.log("Tile requested from custom tileProvider");
                            // return your custom tile here.
                            return null;
                        }
                    });

 gMap.addTileOverlay(new com.google.android.gms.maps.model.TileOverlayOptions().tileProvider(tileProvider));

Please note that I wrote this code without testing it. Here is my approach:
com.google.android.gms.maps.model.TileProvider is an interface so if I want to create an instance I should use new keyword. Also, since the changes in 2.1 so I dropped extend keyword.

Probably I should rewrite it for better readability

 // obtain an instance that implements TileProvider interface with the desired implementation
 var tileProviderInstance = new com.google.android.gms.maps.model.TileProvider({
                        getTile: function(x,y,z){
                             console.log("Tile requested from custom tileProvider");
                            // return your custom tile here.
                            return null;
                        }
                    });

 var options = new com.google.android.gms.maps.model.TileOverlayOptions();
 // use tileProviderInstance
 options.tileProvider(tileProviderInstance);
 gMap.addTileOverlay(options);

Hope this makes it more clear.

Also, I few hours ago I pushed a fix for this issue in master branch. Because of our CI build this means that the change is available is our @next build. If you are eager you can try it using the following command

tns platform remove android
tns platform add android@next

EDIT: I just compared your code and saw that it is the same to what I wrote. If that doesn't work for you please provide the output from adb logcat so I can investigate it further.

[Stavanger75]

Hi @slavchev,

Thanks for adding it to master branch so fast :-) Have now tested the "next" version. For some reason i get the same error using the "extend" as using the "new" keyword.

I could se no major differences from my sample and your sample using the "new" keword.
Both work for me on Android 1.7.1 and none of them seems to work on Android "2.1.1" or "2.2.0-next-2016-07-06-838". Have also tried the extend sample working on Android 1.7.1. on Android "2.2.0-next-2016-07-06-838" but i get the same error as using the "new" keyword.

Do you think their is something wrong on my side or could their still be something not working as expected?. Have tried to remove and add "nativescript", "tns-core-modules", and "android" with no luck. Everything else works perfectly.

Edited: Have now tested on both Windows 10 and Mac (OS X : El Capitan). Width two different projects. (not from the same git repository). And i get the same error.

When it fails the problem still exsist even if i remove the code. So i have to remove and add android again.

• tns platform remove android
• tns platform add android@next

Here are the error message:

WARNING: The file: /ns/testApp/node_modules/nativescript-geolocation/platforms/android/AndroidManifest.xml is depricated, you can read more about what will be the expected plugin structure here: https://www.nativescript.org/blog/migrating-n-android-plugins-from-version-1.7-to-2.0
WARNING: The file: /ns/testApp/node_modules/nativescript-google-maps-sdk/platforms/android/AndroidManifest.xml is depricated, you can read more about what will be the expected plugin structure here: https://www.nativescript.org/blog/migrating-n-android-plugins-from-version-1.7-to-2.0
WARNING: The file: /ns/testApp/node_modules/nativescript-google-maps-sdk/platforms/android/res/values/nativescript_google_maps_api.xml is depricated, you can read more about what will be the expected plugin structure here: https://www.nativescript.org/blog/migrating-n-android-plugins-from-version-1.7-to-2.0

:config phase: createDefaultIncludeFiles
+found plugins: nativescript-floatingactionbutton
+found plugins: nativescript-geolocation
+found plugins: nativescript-google-maps-sdk
+found plugins: tns-core-modules-widgets

:config phase: createPluginsConfigFile
Creating product flavors include.gradle file in /ns/testApp/platforms/android/configurations folder...

:config phase: pluginExtend
+applying configuration from: /ns/testApp/platforms/android/configurations/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/nativescript-floatingactionbutton/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/nativescript-geolocation/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/nativescript-google-maps-sdk/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/tns-core-modules-widgets/include.gradle

:config phase: copyAarDependencies

:config phase: addAarDependencies
+adding dependency: /ns/testApp/platforms/android/libs/aar/widgets-release.aar
:deleteMetadata
:deleteFlavors
:clean

BUILD SUCCESSFUL

Total time: 7.863 secs

This build could be faster, please consider using the Gradle Daemon: https://docs.gradle.org/2.8/userguide/gradle_daemon.html
Successfully prepared plugin nativescript-google-maps-sdk for android.
Project successfully prepared
WARNING: The file: /ns/testApp/node_modules/nativescript-geolocation/platforms/android/AndroidManifest.xml is depricated, you can read more about what will be the expected plugin structure here: https://www.nativescript.org/blog/migrating-n-android-plugins-from-version-1.7-to-2.0
WARNING: The file: /ns/testApp/node_modules/nativescript-google-maps-sdk/platforms/android/AndroidManifest.xml is depricated, you can read more about what will be the expected plugin structure here: https://www.nativescript.org/blog/migrating-n-android-plugins-from-version-1.7-to-2.0
WARNING: The file: /ns/testApp/node_modules/nativescript-google-maps-sdk/platforms/android/res/values/nativescript_google_maps_api.xml is depricated, you can read more about what will be the expected plugin structure here: https://www.nativescript.org/blog/migrating-n-android-plugins-from-version-1.7-to-2.0

:config phase: createDefaultIncludeFiles
+found plugins: nativescript-floatingactionbutton
+found plugins: nativescript-geolocation
+found plugins: nativescript-google-maps-sdk
Renaming plugin directory to flavor name: /ns/testApp/platforms/android/src/nativescript-google-maps-sdk -> /ns/testApp/platforms/android/src/F2
+found plugins: tns-core-modules-widgets

:config phase: createPluginsConfigFile
Creating product flavors include.gradle file in /ns/testApp/platforms/android/configurations folder...

:config phase: pluginExtend
+applying configuration from: /ns/testApp/platforms/android/configurations/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/nativescript-floatingactionbutton/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/nativescript-geolocation/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/nativescript-google-maps-sdk/include.gradle
+applying configuration from: /ns/testApp/platforms/android/configurations/tns-core-modules-widgets/include.gradle

:config phase: copyAarDependencies

:config phase: addAarDependencies
+adding dependency: /ns/testApp/platforms/android/libs/aar/widgets-release.aar
:preBuild UP-TO-DATE
:preF0F1F2F3DebugBuild UP-TO-DATE
:checkF0F1F2F3DebugManifest
:preF0F1F2F3ReleaseBuild UP-TO-DATE
:prepareComAndroidSupportAnimatedVectorDrawable2340Library
:prepareComAndroidSupportAppcompatV72340Library
:prepareComAndroidSupportDesign2340Library
:prepareComAndroidSupportRecyclerviewV72340Library
:prepareComAndroidSupportSupportV42340Library
:prepareComAndroidSupportSupportVectorDrawable2340Library
:prepareComGoogleAndroidGmsPlayServicesBase920Library
:prepareComGoogleAndroidGmsPlayServicesBasement920Library
:prepareComGoogleAndroidGmsPlayServicesMaps920Library
:prepareComGoogleAndroidGmsPlayServicesTasks920Library
:preparetestAppBindingGeneratorUnspecifiedLibrary
:preparetestAppRuntimeUnspecifiedLibrary
:prepareWidgetsReleaseLibrary
:prepareF0F1F2F3DebugDependencies
:compileF0F1F2F3DebugAidl
:compileF0F1F2F3DebugRenderscript
:generateF0F1F2F3DebugBuildConfig
:cleanLocalAarFiles
:ensureMetadataOutDir
:collectAllJars
:setProperties
:asbg:generateInterfaceNamesList
:asbg:runAstParser
inputDir: /ns/testApp/platforms/android/src/main/assets/app
outFile: ../bindings.txt
:asbg:generateBindings
:generateF0F1F2F3DebugAssets UP-TO-DATE
:mergeF0F1F2F3DebugAssets
:generateF0F1F2F3DebugResValues UP-TO-DATE
:generateF0F1F2F3DebugResources
:mergeF0F1F2F3DebugResources
:processF0F1F2F3DebugManifest
:processF0F1F2F3DebugResources
:generateF0F1F2F3DebugSources
:compileF0F1F2F3DebugJavaWithJavac
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:16: error: expected
protected void () {
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:16: error: '(' expected
protected void () {
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:16: error: expected
protected void () {
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:16: error: illegal start of type
protected void () {
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:16: error: expected
protected void () {
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:16: error: ';' expected
protected void () {
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:18: error: expected
com.tns.Runtime.callJSMethod(this, "", void.class, args);
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:18: error: illegal start of type
com.tns.Runtime.callJSMethod(this, "", void.class, args);
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:18: error: illegal start of type
com.tns.Runtime.callJSMethod(this, "", void.class, args);
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:18: error: expected
com.tns.Runtime.callJSMethod(this, "", void.class, args);
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:18: error: ';' expected
com.tns.Runtime.callJSMethod(this, "", void.class, args);
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:18: error: illegal start of type
com.tns.Runtime.callJSMethod(this, "", void.class, args);
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:18: error: ';' expected
com.tns.Runtime.callJSMethod(this, "", void.class, args);
^
/ns/testApp/platforms/android/src/main/java/com/tns/gen/com/google/android/gms/maps/model/TileProvider.java:21: error: class, interface, or enum expected
}
^
14 errors
:compileF0F1F2F3DebugJavaWithJavac FAILED

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':compileF0F1F2F3DebugJavaWithJavac'.

  Compilation failed; see the compiler error output for details.

• Try:
  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 21.635 secs
Command /ns/testApp/platforms/android/gradlew failed with exit code 1

run android

┌──────────────────────┬─────────────────────────────────────────────────────────────────────────────────┐
│ Usage │ Synopsis │
│ Run on all connected │ $ tns run android [--key-store-path --key-store-password │
│ devices and running │ --key-store-alias --key-store-alias-password ] [--release] [- │
│ emulators │ -justlaunch] │
│ Run on a selected │ $ tns run android --device [--key-store-path --key │
│ connected device or │ -store-password --key-store-alias --key-store-alias-password │
│ running emulator │ ] [--release] [--justlaunch] │
│ Start an emulator │ $ tns run android --emulator [] [--key-store-path │
│ and run the app │ --key-store-password --key-store-alias --key-store-alias │
│ inside it │ -password ] [--release] [--justlaunch] │
└──────────────────────┴─────────────────────────────────────────────────────────────────────────────────┘

Runs your project on a connected Android device or in a native Android emulator, if configured. This is shorthand for prepare, build and deploy. While your app is running, prints the output from the application in the console.

Options

* --device - Specifies a connected device on which to run the app.
* --emulator - If set, runs the app in a native emulator for the target platform, if configured. When set, you can also set any other valid combination of emulator options as listed by $ tns help emulate android.
* --release - If set, produces a release build. Otherwise, produces a debug build. When set, you must also specify the --key-store-* options.
* --key-store-path - Specifies the file path to the keystore file (P12) which you want to use to code sign your APK. You can use the --key-store-* options along with --release to produce a signed release build. You need to specify all --key-store-* options.
* --key-store-password - Provides the password for the keystore file specified with --key-store-path. You can use the --key-store-* options along with --release to produce a signed release build. You need to specify all --key-store-* options.
* --key-store-alias - Provides the alias for the keystore file specified with --key-store-path. You can use the --key-store-* options along with --release to produce a signed release build. You need to specify all --key-store-* options.
* --key-store-alias-password - Provides the password for the alias specified with --key-store-alias-password. You can use the --key-store-* options along with --release to produce a signed release build. You need to specify all --key-store-* options.
* --justlaunch - If set, does not print the application output in the console.

Attributes

* <Device ID> is the index or name of the target device as listed by $ tns device android
* <Emulator Options> is any valid combination of options as listed by $ tns help emulate android

[slavchev]

Hi @Stavanger75

Thanks for the log. It was very helpful. There was a bug for interfaces with static initializer for which the Java compiler generates special <clinit> method. I changed the code in static binding generator and push the change into master branch. Now, it should be possible to test if this change works for you.

tns platform remove android
tns platform add android@next

[MiroValchev]

I am pretty sure this is related and still now working with android@next :( Used to work just fine prior to v.2.1

I am using a VLC lib. Here's the problem:

S\platforms\android\src\main\java\com\tns\gen\org\videolan\libvlc\MediaPlayer_EventListener.java:3: error: MediaPlayer_EventListener is not abstract and does not override abstract method onEvent(Event) in Listener
public class MediaPlayer_EventListener implements org.videolan.libvlc.MediaPlayer.EventListener {
       ^
S\platforms\android\src\main\java\com\tns\gen\org\videolan\libvlc\MediaPlayer_EventListener.java:8: error: name clash: onEvent(VLCEvent) in MediaPlayer_EventListener and onEvent(T) in Listener have the same erasure, yet neither overrides the other
        public void onEvent(org.videolan.libvlc.VLCEvent param_0)  {
                    ^
  where T is a type-variable:
    T extends VLCEvent declared in interface Listener
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors
:compileF0F1F2F3F4DebugJavaWithJavac FAILED

FAILURE: Build failed with an exception.

And here's the JAVA:
VLCEvent.java

package org.videolan.libvlc;

public abstract class VLCEvent {
    public final int type;
    public VLCEvent(int type) {
        this.type = type;
    }

    /**
     * Listener for libvlc events
     *
     * @see VLCEvent
     */
    public interface Listener<T extends VLCEvent> {
        void onEvent(T event);
    }
}

and the problem:
MediaPlayer.java

public interface EventListener extends VLCEvent.Listener<MediaPlayer.Event> {}