Skip to content

Conversation

darind
Copy link
Collaborator

@darind darind commented May 17, 2018

Related to #1062.

Add support for the new gradle 4.4 flavor dimension configurations.

This PR fixes an issue if custom dimensions are used in app/App_Resources/Android/app.gradle:

flavorDimensions "arch", "mode"

productFlavors {
  demo {
    dimension "mode"
  }
  full {
    dimension "mode"
  }
  x86 {
    dimension "arch"
  }
  arm {
    dimension "arch"
  }
  arm64 {
    dimension "arch"
  }
}

The build will fail with:

Could not get unknown property 'debugCompileClasspath' for configuration container of type org.gradle.api.internal.artifacts.configurations.DefaultConfigurationContainer

@darind darind force-pushed the darind/gradle-flavor-dimensions-fix branch from 8c2891a to 6e86080 Compare May 17, 2018 09:27
@darind darind force-pushed the darind/gradle-flavor-dimensions-fix branch from 6e86080 to df582d8 Compare May 17, 2018 10:53
@darind darind merged commit 0382d33 into master May 17, 2018
@darind darind deleted the darind/gradle-flavor-dimensions-fix branch May 17, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants