Add support for indirect ByteBuffer #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darind
approved these changes
May 18, 2018
|
@vtrifonov Thanks for the quick fix, but I want to know any possibility to reuse the reference of the byte array without memory copy,like the direct byte buffer? This could be more faster. |
|
@andy-maca I don't think it's possible to reuse the reference of an indirect ByteBuffer. In JNI you can only get the address of a direct buffer with GetDirectBufferAddress. |
|
Ok, fine, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1060
Now we support indirect ByteBuffers, however they are slower as we are copying the buffer content to the result array.