Revert back to v8 6.7.288.46 #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test |
|
test animations api24 |
vtrifonov
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting back to V8 6.7.288.46 because of issues with
MarkReachableObjectsmethod. In the newer versions of V8 the internal API that we use to collect the closure objects has been removed and the new API doesn't appear to be working in certain situations (for example the from-code CSS animation in the https://github.com/NativeScript/animation-demo sample).Further investigation is required in order to handle this situation with the new V8.
The long term solution would be to make marking mode
Nonethe default option.