feat: bump supportVer fallback value to 28.0.0 #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darind
approved these changes
Oct 23, 2018
manoldonev
added a commit
that referenced
this pull request
Oct 24, 2018
Use implementation instead of debugImplementation for com.android.support:design. This fixes a release build error for master/detail template with compile sdk 28 / support library 28.0.0. Related to #1193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to NativeScript/tns-core-modules-widgets#145
Related to NativeScript/nativescript-cli#3992
In theory bumping up the same value in the widgets PR should ensure that Android is smart enough to use the latest version of the support library required by any of the app dependencies but in any case the println would be misleading: https://github.com/NativeScript/android-runtime/blob/b440a4687dfd212b2b1905563466b583f01ff4e1/test-app/app/build.gradle#L265